Skip to content

Commit 3e74ec2

Browse files
quic-bjorandeandersson
authored andcommitted
rpmsg: glink: Avoid infinite loop on intent for missing channel
In the event that an intent advertisement arrives on an unknown channel the fifo is not advanced, resulting in the same message being handled over and over. Fixes: dacbb35 ("rpmsg: glink: Receive and store the remote intent buffers") Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Reviewed-by: Chris Lew <quic_clew@quicinc.com> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20230214234231.2069751-1-quic_bjorande@quicinc.com
1 parent 4e816d0 commit 3e74ec2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/rpmsg/qcom_glink_native.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -966,6 +966,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink,
966966
spin_unlock_irqrestore(&glink->idr_lock, flags);
967967
if (!channel) {
968968
dev_err(glink->dev, "intents for non-existing channel\n");
969+
qcom_glink_rx_advance(glink, ALIGN(msglen, 8));
969970
return;
970971
}
971972

0 commit comments

Comments
 (0)