Skip to content

Commit 46f91ad

Browse files
author
Danilo Krummrich
committed
rust: revocable: implement Revocable::access()
Implement an unsafe direct accessor for the data stored within the Revocable. This is useful for cases where we can prove that the data stored within the Revocable is not and cannot be revoked for the duration of the lifetime of the returned reference. Reviewed-by: Christian Schrefl <chrisi.schrefl@gmail.com> Reviewed-by: Benno Lossin <benno.lossin@proton.me> Acked-by: Miguel Ojeda <ojeda@kernel.org> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> Acked-by: Boqun Feng <boqun.feng@gmail.com> Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com> Link: https://lore.kernel.org/r/20250428140137.468709-2-dakr@kernel.org Signed-off-by: Danilo Krummrich <dakr@kernel.org>
1 parent fc55584 commit 46f91ad

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

rust/kernel/revocable.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,18 @@ impl<T> Revocable<T> {
139139
self.try_access().map(|t| f(&*t))
140140
}
141141

142+
/// Directly access the revocable wrapped object.
143+
///
144+
/// # Safety
145+
///
146+
/// The caller must ensure this [`Revocable`] instance hasn't been revoked and won't be revoked
147+
/// as long as the returned `&T` lives.
148+
pub unsafe fn access(&self) -> &T {
149+
// SAFETY: By the safety requirement of this function it is guaranteed that
150+
// `self.data.get()` is a valid pointer to an instance of `T`.
151+
unsafe { &*self.data.get() }
152+
}
153+
142154
/// # Safety
143155
///
144156
/// Callers must ensure that there are no more concurrent users of the revocable object.

0 commit comments

Comments
 (0)