Skip to content

Commit 477327e

Browse files
Zheng Yejianakpm00
authored andcommitted
mm/damon/vaddr: add 'nr_piece == 1' check in damon_va_evenly_split_region()
As discussed in [1], damon_va_evenly_split_region() is called to size-evenly split a region into 'nr_pieces' small regions, when nr_pieces == 1, no actual split is required. Check that case for better code readability and add a simple kunit testcase. [1] https://lore.kernel.org/all/20241021163316.12443-1-sj@kernel.org/ Link: https://lkml.kernel.org/r/20241022083927.3592237-3-zhengyejian@huaweicloud.com Signed-off-by: Zheng Yejian <zhengyejian@huaweicloud.com> Reviewed-by: SeongJae Park <sj@kernel.org> Cc: Fernand Sieber <sieberf@amazon.com> Cc: Leonard Foerster <foersleo@amazon.de> Cc: Shakeel Butt <shakeel.butt@linux.dev> Cc: Ye Weihua <yeweihua4@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent f3c7a1e commit 477327e

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

mm/damon/tests/vaddr-kunit.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ static void damon_test_split_evenly(struct kunit *test)
300300
damon_test_split_evenly_fail(test, 0, 100, 0);
301301
damon_test_split_evenly_succ(test, 0, 100, 10);
302302
damon_test_split_evenly_succ(test, 5, 59, 5);
303+
damon_test_split_evenly_succ(test, 4, 6, 1);
303304
damon_test_split_evenly_succ(test, 0, 3, 2);
304305
damon_test_split_evenly_fail(test, 5, 6, 2);
305306
}

mm/damon/vaddr.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ static int damon_va_evenly_split_region(struct damon_target *t,
7272
if (!r || !nr_pieces)
7373
return -EINVAL;
7474

75+
if (nr_pieces == 1)
76+
return 0;
77+
7578
orig_end = r->ar.end;
7679
sz_orig = damon_sz_region(r);
7780
sz_piece = ALIGN_DOWN(sz_orig / nr_pieces, DAMON_MIN_REGION);

0 commit comments

Comments
 (0)