Skip to content

Commit 4aadde8

Browse files
compudjrostedt
authored andcommitted
tracing/bpf: disable preemption in syscall probe
In preparation for allowing system call enter/exit instrumentation to handle page faults, make sure that bpf can handle this change by explicitly disabling preemption within the bpf system call tracepoint probes to respect the current expectations within bpf tracing code. This change does not yet allow bpf to take page faults per se within its probe, but allows its existing probes to adapt to the upcoming change. Cc: Michael Jeanson <mjeanson@efficios.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Yonghong Song <yhs@fb.com> Cc: Paul E. McKenney <paulmck@kernel.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com> Cc: bpf@vger.kernel.org Cc: Joel Fernandes <joel@joelfernandes.org> Link: https://lore.kernel.org/20241009010718.2050182-5-mathieu.desnoyers@efficios.com Acked-by: Andrii Nakryiko <andrii@kernel.org> Tested-by: Andrii Nakryiko <andrii@kernel.org> # BPF parts Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 65e7462 commit 4aadde8

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

include/trace/bpf_probe.h

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,18 @@ __bpf_trace_##call(void *__data, proto) \
5353
#define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \
5454
__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args))
5555

56+
#define __BPF_DECLARE_TRACE_SYSCALL(call, proto, args) \
57+
static notrace void \
58+
__bpf_trace_##call(void *__data, proto) \
59+
{ \
60+
preempt_disable_notrace(); \
61+
CONCATENATE(bpf_trace_run, COUNT_ARGS(args))(__data, CAST_TO_U64(args)); \
62+
preempt_enable_notrace(); \
63+
}
64+
5665
#undef DECLARE_EVENT_SYSCALL_CLASS
57-
#define DECLARE_EVENT_SYSCALL_CLASS DECLARE_EVENT_CLASS
66+
#define DECLARE_EVENT_SYSCALL_CLASS(call, proto, args, tstruct, assign, print) \
67+
__BPF_DECLARE_TRACE_SYSCALL(call, PARAMS(proto), PARAMS(args))
5868

5969
/*
6070
* This part is compiled out, it is only here as a build time check

0 commit comments

Comments
 (0)