drm/scheduler: fix drm_sched_job_add_implicit_dependencies

ChristianKoenigAMD · ChristianKoenigAMD · commit 4eaf02d6076c · 2021-11-16T10:00:58.000+01:00
Trivial fix since we now need to grab a reference to the fence we have added. Previously the dma_resv function where doing that for us. Signed-off-by: Christian König <christian.koenig@amd.com> Fixes: 9c2ba26 ("drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2") Link: https://patchwork.freedesktop.org/patch/msgid/20211019112706.27769-1-christian.koenig@amd.com Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reported-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/ Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Tested-by: Yassine Oudjana <y.oudjana@protonmail.com>
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
@@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job,
 		ret = drm_sched_job_add_dependency(job, fence);
 		if (ret)
 			return ret;
+
+		/* Make sure to grab an additional ref on the added fence */
+		dma_fence_get(fence);
 	}
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job,`
`707`	`707`	`ret = drm_sched_job_add_dependency(job, fence);`
`708`	`708`	`if (ret)`
`709`	`709`	`return ret;`
	`710`	`+`
	`711`	`+ /* Make sure to grab an additional ref on the added fence */`
	`712`	`+ dma_fence_get(fence);`
`710`	`713`	`}`
`711`	`714`	`return 0;`
`712`	`715`	`}`