Skip to content

Commit 50a8c08

Browse files
author
Liu Ying
committed
drm/bridge: analogix_dp: Fix bailout for devm_drm_bridge_alloc()
devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a NULL pointer, so use IS_ERR() to check the returned pointer. While at it, on failure, return ERR_CAST(dp) instead of ERR_PTR(-ENOMEM) in order not to depend on devm_drm_bridge_alloc() error code implementation. Fixes: 48f05c3 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API") Signed-off-by: Liu Ying <victor.liu@nxp.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Link: https://lore.kernel.org/r/20250806095224.527938-1-victor.liu@nxp.com
1 parent a52dffa commit 50a8c08

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,8 +1474,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
14741474

14751475
dp = devm_drm_bridge_alloc(dev, struct analogix_dp_device, bridge,
14761476
&analogix_dp_bridge_funcs);
1477-
if (!dp)
1478-
return ERR_PTR(-ENOMEM);
1477+
if (IS_ERR(dp))
1478+
return ERR_CAST(dp);
14791479

14801480
dp->dev = &pdev->dev;
14811481
dp->dpms_mode = DRM_MODE_DPMS_OFF;

0 commit comments

Comments
 (0)