Skip to content

Commit 53d067f

Browse files
Leo-Yanacmel
authored andcommitted
tools build: Align warning options with perf
The feature test programs are built without enabling '-Wall -Werror' options. As a result, a feature may appear to be available, but later building in perf can fail with stricter checks. Make the feature test program use the same warning options as perf. Fixes: 1925459 ("tools build: Fix feature Makefile issues with 'O='") Signed-off-by: Leo Yan <leo.yan@arm.com> Reviewed-by: Ian Rogers <irogers@google.com> Link: https://lore.kernel.org/r/20251006-perf_build_android_ndk-v3-1-4305590795b2@arm.com Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: Alexandre Ghiti <alex@ghiti.fr> Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com> Cc: Justin Stitt <justinstitt@google.com> Cc: Bill Wendling <morbo@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: James Clark <james.clark@linaro.org> Cc: linux-riscv@lists.infradead.org Cc: llvm@lists.linux.dev Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: linux-kernel@vger.kernel.org Cc: linux-perf-users@vger.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent e3b08a0 commit 53d067f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/build/feature/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,10 +307,10 @@ $(OUTPUT)test-libcapstone.bin:
307307
$(BUILD) # -lcapstone provided by $(FEATURE_CHECK_LDFLAGS-libcapstone)
308308

309309
$(OUTPUT)test-compile-32.bin:
310-
$(CC) -m32 -o $@ test-compile.c
310+
$(CC) -m32 -Wall -Werror -o $@ test-compile.c
311311

312312
$(OUTPUT)test-compile-x32.bin:
313-
$(CC) -mx32 -o $@ test-compile.c
313+
$(CC) -mx32 -Wall -Werror -o $@ test-compile.c
314314

315315
$(OUTPUT)test-zlib.bin:
316316
$(BUILD) -lz

0 commit comments

Comments
 (0)