Skip to content

Commit 58b42c9

Browse files
andy-shevmartinkpetersen
authored andcommitted
scsi: fnic: Switch to use %ptTs
Use %ptTs instead of open-coded variant to print contents of time64_t type in human readable form. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230314145813.66112-1-andriy.shevchenko@linux.intel.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 1efbacd commit 58b42c9

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

drivers/scsi/fnic/fnic_trace.c

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -781,28 +781,21 @@ void copy_and_format_trace_data(struct fc_trace_hdr *tdata,
781781
fnic_dbgfs_t *fnic_dbgfs_prt, int *orig_len,
782782
u8 rdata_flag)
783783
{
784-
struct tm tm;
785784
int j, i = 1, len;
786-
char *fc_trace, *fmt;
787785
int ethhdr_len = sizeof(struct ethhdr) - 1;
788786
int fcoehdr_len = sizeof(struct fcoe_hdr);
789787
int fchdr_len = sizeof(struct fc_frame_header);
790788
int max_size = fnic_fc_trace_max_pages * PAGE_SIZE * 3;
789+
char *fc_trace;
791790

792791
tdata->frame_type = tdata->frame_type & 0x7F;
793792

794793
len = *orig_len;
795794

796-
time64_to_tm(tdata->time_stamp.tv_sec, 0, &tm);
797-
798-
fmt = "%02d:%02d:%04ld %02d:%02d:%02d.%09lu ns%8x %c%8x\t";
799-
len += scnprintf(fnic_dbgfs_prt->buffer + len,
800-
max_size - len,
801-
fmt,
802-
tm.tm_mon + 1, tm.tm_mday, tm.tm_year + 1900,
803-
tm.tm_hour, tm.tm_min, tm.tm_sec,
804-
tdata->time_stamp.tv_nsec, tdata->host_no,
805-
tdata->frame_type, tdata->frame_len);
795+
len += scnprintf(fnic_dbgfs_prt->buffer + len, max_size - len,
796+
"%ptTs.%09lu ns%8x %c%8x\t",
797+
&tdata->time_stamp.tv_sec, tdata->time_stamp.tv_nsec,
798+
tdata->host_no, tdata->frame_type, tdata->frame_len);
806799

807800
fc_trace = (char *)FC_TRACE_ADDRESS(tdata);
808801

0 commit comments

Comments
 (0)