cpufreq: loongson2: Unregister platform_driver on failure

Yuan Can · vireshk · commit 5f856d71ccdf · 2024-10-16T15:20:21.000+05:30
When cpufreq_register_driver() returns error, the cpufreq_init() returns without unregister platform_driver, fix by add missing platform_driver_unregister() when cpufreq_register_driver() failed. Fixes: f8ede0f ("MIPS: Loongson 2F: Add CPU frequency scaling support") Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
@@ -148,7 +148,9 @@ static int __init cpufreq_init(void)
 
 	ret = cpufreq_register_driver(&loongson2_cpufreq_driver);
 
-	if (!ret && !nowait) {
+	if (ret) {
+		platform_driver_unregister(&platform_driver);
+	} else if (!nowait) {
 		saved_cpu_wait = cpu_wait;
 		cpu_wait = loongson2_cpu_wait;
 	}

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,9 @@ static int __init cpufreq_init(void)`
`148`	`148`
`149`	`149`	`ret = cpufreq_register_driver(&loongson2_cpufreq_driver);`
`150`	`150`
`151`		`- if (!ret && !nowait) {`
	`151`	`+ if (ret) {`
	`152`	`+ platform_driver_unregister(&platform_driver);`
	`153`	`+ } else if (!nowait) {`
`152`	`154`	`saved_cpu_wait = cpu_wait;`
`153`	`155`	`cpu_wait = loongson2_cpu_wait;`
`154`	`156`	`}`