Skip to content

Commit 65beb57

Browse files
committed
perf probe: Fix uninitialized variable
JIRA: https://issues.redhat.com/browse/RHEL-77935 upstream ======== commit 434fffa Author: James Clark <james.clark@linaro.org> Date: Wed Dec 11 08:55:23 2024 +0000 description =========== Since the linked fixes: commit, err is returned uninitialized due to the removal of "return 0". Initialize err to fix it. This fixes the following intermittent test failure on release builds: $ perf test "testsuite_probe" ... -- [ FAIL ] -- perf_probe :: test_invalid_options :: mutually exclusive options :: -L foo -V bar (output regexp parsing) Regexp not found: \"Error: switch .+ cannot be used with switch .+\" ... Fixes: 080e47b ("perf probe: Introduce quotation marks support") Tested-by: Namhyung Kim <namhyung@kernel.org> Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Signed-off-by: James Clark <james.clark@linaro.org> Link: https://lore.kernel.org/r/20241211085525.519458-2-james.clark@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
1 parent 43ad3af commit 65beb57

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/perf/util/probe-event.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1370,7 +1370,7 @@ int parse_line_range_desc(const char *arg, struct line_range *lr)
13701370
{
13711371
char *buf = strdup(arg);
13721372
char *p;
1373-
int err;
1373+
int err = 0;
13741374

13751375
if (!buf)
13761376
return -ENOMEM;

0 commit comments

Comments
 (0)