Skip to content

Commit 6a7d68f

Browse files
Dr. David Alan Gilbertkuba-moo
authored andcommitted
net: ena: Remove deadcode
ena_com_get_dev_basic_stats() has been unused since 2017's commit d81db24 ("net/ena: refactor ena_get_stats64 to be atomic context safe") ena_com_get_offload_settings() has been unused since the original commit of ENA back in 2016 in commit 1738cd3 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Remove them. Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Reviewed-by: David Arinzon <darinzon@amazon.com> Link: https://patch.msgid.link/20241102220142.80285-1-linux@treblig.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b356b91 commit 6a7d68f

File tree

2 files changed

+0
-51
lines changed

2 files changed

+0
-51
lines changed

drivers/net/ethernet/amazon/ena/ena_com.c

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -2183,21 +2183,6 @@ int ena_com_get_ena_srd_info(struct ena_com_dev *ena_dev,
21832183
return ret;
21842184
}
21852185

2186-
int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
2187-
struct ena_admin_basic_stats *stats)
2188-
{
2189-
struct ena_com_stats_ctx ctx;
2190-
int ret;
2191-
2192-
memset(&ctx, 0x0, sizeof(ctx));
2193-
ret = ena_get_dev_stats(ena_dev, &ctx, ENA_ADMIN_GET_STATS_TYPE_BASIC);
2194-
if (likely(ret == 0))
2195-
memcpy(stats, &ctx.get_resp.u.basic_stats,
2196-
sizeof(ctx.get_resp.u.basic_stats));
2197-
2198-
return ret;
2199-
}
2200-
22012186
int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32 len)
22022187
{
22032188
struct ena_admin_aq_get_stats_cmd *get_cmd;
@@ -2274,24 +2259,6 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu)
22742259
return ret;
22752260
}
22762261

2277-
int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
2278-
struct ena_admin_feature_offload_desc *offload)
2279-
{
2280-
int ret;
2281-
struct ena_admin_get_feat_resp resp;
2282-
2283-
ret = ena_com_get_feature(ena_dev, &resp,
2284-
ENA_ADMIN_STATELESS_OFFLOAD_CONFIG, 0);
2285-
if (unlikely(ret)) {
2286-
netdev_err(ena_dev->net_device, "Failed to get offload capabilities %d\n", ret);
2287-
return ret;
2288-
}
2289-
2290-
memcpy(offload, &resp.u.offload, sizeof(resp.u.offload));
2291-
2292-
return 0;
2293-
}
2294-
22952262
int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
22962263
{
22972264
struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;

drivers/net/ethernet/amazon/ena/ena_com.h

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -577,15 +577,6 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag);
577577
int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,
578578
struct ena_com_dev_get_features_ctx *get_feat_ctx);
579579

580-
/* ena_com_get_dev_basic_stats - Get device basic statistics
581-
* @ena_dev: ENA communication layer struct
582-
* @stats: stats return value
583-
*
584-
* @return: 0 on Success and negative value otherwise.
585-
*/
586-
int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
587-
struct ena_admin_basic_stats *stats);
588-
589580
/* ena_com_get_eni_stats - Get extended network interface statistics
590581
* @ena_dev: ENA communication layer struct
591582
* @stats: stats return value
@@ -621,15 +612,6 @@ int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32
621612
*/
622613
int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu);
623614

624-
/* ena_com_get_offload_settings - Retrieve the device offloads capabilities
625-
* @ena_dev: ENA communication layer struct
626-
* @offlad: offload return value
627-
*
628-
* @return: 0 on Success and negative value otherwise.
629-
*/
630-
int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
631-
struct ena_admin_feature_offload_desc *offload);
632-
633615
/* ena_com_rss_init - Init RSS
634616
* @ena_dev: ENA communication layer struct
635617
* @log_size: indirection log size

0 commit comments

Comments
 (0)