Skip to content

Commit 6ae2ff2

Browse files
geertueffective-light
authored andcommitted
drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()
Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), which uses bpp and depth to guess the wanted buffer format. However, drm_client_buffer_addfb() already knows the exact buffer format, so there is no need to convert back and forth between buffer format and bpp/depth, and the function can just call drm_mode_addfb2() directly instead. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Tested-by: Javier Martinez Canillas <javierm@redhat.com> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/4b84adfc686288714e69d0442d22f1259ff74903.1697379891.git.geert@linux-m68k.org
1 parent f70a669 commit 6ae2ff2

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

drivers/gpu/drm/drm_client.c

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -395,19 +395,16 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer,
395395
u32 handle)
396396
{
397397
struct drm_client_dev *client = buffer->client;
398-
struct drm_mode_fb_cmd fb_req = { };
399-
const struct drm_format_info *info;
398+
struct drm_mode_fb_cmd2 fb_req = { };
400399
int ret;
401400

402-
info = drm_format_info(format);
403-
fb_req.bpp = drm_format_info_bpp(info, 0);
404-
fb_req.depth = info->depth;
405401
fb_req.width = width;
406402
fb_req.height = height;
407-
fb_req.handle = handle;
408-
fb_req.pitch = buffer->pitch;
403+
fb_req.pixel_format = format;
404+
fb_req.handles[0] = handle;
405+
fb_req.pitches[0] = buffer->pitch;
409406

410-
ret = drm_mode_addfb(client->dev, &fb_req, client->file);
407+
ret = drm_mode_addfb2(client->dev, &fb_req, client->file);
411408
if (ret)
412409
return ret;
413410

0 commit comments

Comments
 (0)