Skip to content

Commit 6b9da26

Browse files
captain5050acmel
authored andcommitted
perf pmu: Remove is_pmu_hybrid
Users have been removed or switched to using pmu->is_core with perf_pmus__num_core_pmus() > 1. Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Signed-off-by: Ian Rogers <irogers@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ali Saidi <alisaidi@amazon.com> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Cc: Dmitrii Dolgov <9erthalion6@gmail.com> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@arm.com> Cc: Jing Zhang <renyu.zj@linux.alibaba.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: John Garry <john.g.garry@oracle.com> Cc: Kajol Jain <kjain@linux.ibm.com> Cc: Kang Minchul <tegongkang@gmail.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Madhavan Srinivasan <maddy@linux.ibm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mike Leach <mike.leach@linaro.org> Cc: Ming Wang <wangming01@loongson.cn> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Rob Herring <robh@kernel.org> Cc: Sandipan Das <sandipan.das@amd.com> Cc: Sean Christopherson <seanjc@google.com> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: Thomas Richter <tmricht@linux.ibm.com> Cc: Will Deacon <will@kernel.org> Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com> Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: https://lore.kernel.org/r/20230527072210.2900565-35-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 94f9eb9 commit 6b9da26

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

tools/perf/util/pmu.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1417,19 +1417,14 @@ bool is_pmu_core(const char *name)
14171417
return !strcmp(name, "cpu") || is_sysfs_pmu_core(name);
14181418
}
14191419

1420-
bool is_pmu_hybrid(const char *name)
1421-
{
1422-
return !strcmp(name, "cpu_atom") || !strcmp(name, "cpu_core");
1423-
}
1424-
14251420
bool perf_pmu__supports_legacy_cache(const struct perf_pmu *pmu)
14261421
{
14271422
return pmu->is_core;
14281423
}
14291424

14301425
bool perf_pmu__auto_merge_stats(const struct perf_pmu *pmu)
14311426
{
1432-
return !is_pmu_hybrid(pmu->name);
1427+
return pmu->is_core && perf_pmus__num_core_pmus() > 1;
14331428
}
14341429

14351430
bool perf_pmu__have_event(const struct perf_pmu *pmu, const char *name)

tools/perf/util/pmu.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ int perf_pmu__format_parse(int dirfd, struct list_head *head);
221221
void perf_pmu__del_formats(struct list_head *formats);
222222

223223
bool is_pmu_core(const char *name);
224-
bool is_pmu_hybrid(const char *name);
225224
bool perf_pmu__supports_legacy_cache(const struct perf_pmu *pmu);
226225
bool perf_pmu__auto_merge_stats(const struct perf_pmu *pmu);
227226
bool perf_pmu__have_event(const struct perf_pmu *pmu, const char *name);

0 commit comments

Comments
 (0)