Skip to content

Commit 6d36f65

Browse files
mattropelucasdemarchi
authored andcommitted
drm/xe/kunit: Fix kerneldoc for parameterized tests
Kunit's generate_params() was recently updated to take an additional test context parameter. Xe's IP and platform parameter generators were updated accordingly at the same time, but the new parameter was not added to the functions' kerneldoc, resulting in the following warnings: Warning: drivers/gpu/drm/xe/tests/xe_pci.c:78 function parameter 'test' not described in 'xe_pci_fake_data_gen_params' Warning: drivers/gpu/drm/xe/tests/xe_pci.c:254 function parameter 'test' not described in 'xe_pci_graphics_ip_gen_param' Warning: drivers/gpu/drm/xe/tests/xe_pci.c:278 function parameter 'test' not described in 'xe_pci_media_ip_gen_param' Warning: drivers/gpu/drm/xe/tests/xe_pci.c:302 function parameter 'test' not described in 'xe_pci_id_gen_param' Warning: drivers/gpu/drm/xe/tests/xe_pci.c:390 function parameter 'test' not described in 'xe_pci_live_device_gen_param' 5 warnings as errors Document the new parameter to eliminate the warnings and make CI happy. Fixes: b9a214b ("kunit: Pass parameterized test context to generate_params()") Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com> Link: https://lore.kernel.org/r/20251013153014.2362879-2-matthew.d.roper@intel.com Signed-off-by: Matt Roper <matthew.d.roper@intel.com> (cherry picked from commit 89e347f8a70165d1e8d88a93d875da7742c902ce) Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
1 parent 7987b93 commit 6d36f65

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/gpu/drm/xe/tests/xe_pci.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ KUNIT_ARRAY_PARAM(platform, cases, xe_pci_fake_data_desc);
6666

6767
/**
6868
* xe_pci_fake_data_gen_params - Generate struct xe_pci_fake_data parameters
69+
* @test: test context object
6970
* @prev: the pointer to the previous parameter to iterate from or NULL
7071
* @desc: output buffer with minimum size of KUNIT_PARAM_DESC_SIZE
7172
*
@@ -242,6 +243,7 @@ KUNIT_ARRAY_PARAM(pci_id, pciidlist, xe_pci_id_kunit_desc);
242243

243244
/**
244245
* xe_pci_graphics_ip_gen_param - Generate graphics struct xe_ip parameters
246+
* @test: test context object
245247
* @prev: the pointer to the previous parameter to iterate from or NULL
246248
* @desc: output buffer with minimum size of KUNIT_PARAM_DESC_SIZE
247249
*
@@ -266,6 +268,7 @@ EXPORT_SYMBOL_IF_KUNIT(xe_pci_graphics_ip_gen_param);
266268

267269
/**
268270
* xe_pci_media_ip_gen_param - Generate media struct xe_ip parameters
271+
* @test: test context object
269272
* @prev: the pointer to the previous parameter to iterate from or NULL
270273
* @desc: output buffer with minimum size of KUNIT_PARAM_DESC_SIZE
271274
*
@@ -290,6 +293,7 @@ EXPORT_SYMBOL_IF_KUNIT(xe_pci_media_ip_gen_param);
290293

291294
/**
292295
* xe_pci_id_gen_param - Generate struct pci_device_id parameters
296+
* @test: test context object
293297
* @prev: the pointer to the previous parameter to iterate from or NULL
294298
* @desc: output buffer with minimum size of KUNIT_PARAM_DESC_SIZE
295299
*
@@ -376,6 +380,7 @@ EXPORT_SYMBOL_IF_KUNIT(xe_pci_fake_device_init);
376380

377381
/**
378382
* xe_pci_live_device_gen_param - Helper to iterate Xe devices as KUnit parameters
383+
* @test: test context object
379384
* @prev: the previously returned value, or NULL for the first iteration
380385
* @desc: the buffer for a parameter name
381386
*

0 commit comments

Comments
 (0)