Skip to content

Commit 6d8e294

Browse files
committed
RAS/CEC: Fix pfn insertion
When inserting random PFNs for debugging the CEC through (debugfs)/ras/cec/pfn, depending on the return value of pfn_set(), multiple values get inserted per a single write. That is because simple_attr_write() interprets a retval of 0 as success and claims the whole input. However, pfn_set() returns the cec_add_elem() value, which, if > 0 and smaller than the whole input length, makes glibc continue issuing the write syscall until there's input left: pfn_set simple_attr_write debugfs_attr_write full_proxy_write vfs_write ksys_write do_syscall_64 entry_SYSCALL_64_after_hwframe leading to those repeated calls. Return 0 to fix that. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Tony Luck <tony.luck@intel.com> Cc: linux-edac <linux-edac@vger.kernel.org>
1 parent 0ade0b6 commit 6d8e294

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/ras/cec.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,9 @@ static int pfn_set(void *data, u64 val)
369369
{
370370
*(u64 *)data = val;
371371

372-
return cec_add_elem(val);
372+
cec_add_elem(val);
373+
374+
return 0;
373375
}
374376

375377
DEFINE_DEBUGFS_ATTRIBUTE(pfn_ops, u64_get, pfn_set, "0x%llx\n");

0 commit comments

Comments
 (0)