sunrpc/svc: use store_release_wake_up()

neilbrown · chucklever · commit 6e1d75f778d6 · 2025-01-06T09:37:34.000-05:00
svc_thread_init_status() contains an open-coded
store_release_wake_up().  It is cleaner to use that function directly
rather than needing to remember the barrier.

Signed-off-by: NeilBrown &lt;neilb@suse.de&gt;
Reviewed-by: Jeff Layton &lt;jlayton@kernel.org&gt;
Signed-off-by: Chuck Lever &lt;chuck.lever@oracle.com&gt;
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
@@ -327,12 +327,7 @@ static inline bool svc_thread_should_stop(struct svc_rqst *rqstp)
  */
 static inline void svc_thread_init_status(struct svc_rqst *rqstp, int err)
 {
-	rqstp->rq_err = err;
-	/* memory barrier ensures assignment to error above is visible before
-	 * waitqueue_active() test below completes.
-	 */
-	smp_mb();
-	wake_up_var(&rqstp->rq_err);
+	store_release_wake_up(&rqstp->rq_err, err);
 	if (err)
 		kthread_exit(1);
 }

Original file line number	Diff line number	Diff line change
`@@ -327,12 +327,7 @@ static inline bool svc_thread_should_stop(struct svc_rqst *rqstp)`
`327`	`327`	`*/`
`328`	`328`	`static inline void svc_thread_init_status(struct svc_rqst *rqstp, int err)`
`329`	`329`	`{`
`330`		`- rqstp->rq_err = err;`
`331`		`- /* memory barrier ensures assignment to error above is visible before`
`332`		`- * waitqueue_active() test below completes.`
`333`		`- */`
`334`		`- smp_mb();`
`335`		`- wake_up_var(&rqstp->rq_err);`
	`330`	`+ store_release_wake_up(&rqstp->rq_err, err);`
`336`	`331`	`if (err)`
`337`	`332`	`kthread_exit(1);`
`338`	`333`	`}`