Skip to content

Commit 74894ff

Browse files
pldrcalexdeucher
authored andcommitted
drm/amdgpu: Add ring reset callback for JPEG4_0_0
Add ring reset function callback for JPEG4_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com> Acked-by: Christian König <christian.koenig@amd.com> Reviewed-by: Leo Liu <leo.liu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent abce7b4 commit 74894ff

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,10 @@ static int jpeg_v4_0_sw_init(struct amdgpu_ip_block *ip_block)
143143
if (r)
144144
return r;
145145

146-
/* TODO: Add queue reset mask when FW fully supports it */
147-
adev->jpeg.supported_reset =
148-
amdgpu_get_soft_full_reset_mask(&adev->jpeg.inst[0].ring_dec[0]);
146+
adev->jpeg.supported_reset = AMDGPU_RESET_TYPE_PER_QUEUE;
149147
r = amdgpu_jpeg_sysfs_reset_mask_init(adev);
150-
if (r)
151-
return r;
152148

153-
return 0;
149+
return r;
154150
}
155151

156152
/**
@@ -724,6 +720,16 @@ static int jpeg_v4_0_process_interrupt(struct amdgpu_device *adev,
724720
return 0;
725721
}
726722

723+
static int jpeg_v4_0_ring_reset(struct amdgpu_ring *ring, unsigned int vmid)
724+
{
725+
if (amdgpu_sriov_vf(ring->adev))
726+
return -EINVAL;
727+
728+
jpeg_v4_0_stop(ring->adev);
729+
jpeg_v4_0_start(ring->adev);
730+
return amdgpu_ring_test_helper(ring);
731+
}
732+
727733
static const struct amd_ip_funcs jpeg_v4_0_ip_funcs = {
728734
.name = "jpeg_v4_0",
729735
.early_init = jpeg_v4_0_early_init,
@@ -769,6 +775,7 @@ static const struct amdgpu_ring_funcs jpeg_v4_0_dec_ring_vm_funcs = {
769775
.emit_wreg = jpeg_v2_0_dec_ring_emit_wreg,
770776
.emit_reg_wait = jpeg_v2_0_dec_ring_emit_reg_wait,
771777
.emit_reg_write_reg_wait = amdgpu_ring_emit_reg_write_reg_wait_helper,
778+
.reset = jpeg_v4_0_ring_reset,
772779
};
773780

774781
static void jpeg_v4_0_set_dec_ring_funcs(struct amdgpu_device *adev)

0 commit comments

Comments
 (0)