Skip to content

Commit 75959d4

Browse files
KAGA-KOKOmasahir0y
authored andcommitted
kbuild: Fail if gold linker is detected
The gold linker has known issues of failing the build both in random and in predictible ways: - The x86/X32 VDSO build fails with: arch/x86/entry/vdso/vclock_gettime-x32.o:vclock_gettime.c:function do_hres: error: relocation overflow: reference to 'hvclock_page' That's a known issue for years and the usual workaround is to disable CONFIG_X86_32 - A recent build failure is caused by turning a relocation into an absolute one for unknown reasons. See link below. - There are a couple of gold workarounds applied already, but reports about broken builds with ld.gold keep coming in on a regular base and in most cases the root cause is unclear. In context of the most recent fail H.J. stated: "Since building a workable kernel for different kernel configurations isn't a requirement for gold, I don't recommend gold for kernel." So instead of dealing with attempts to duct tape gold support without understanding the root cause and without support from the gold folks, fail the build when gold is detected. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/CAMe9rOqMqkQ0LNpm25yE_Yt0FKp05WmHOrwc0aRDb53miFKM+w@mail.gmail.com Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Tested-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
1 parent 15bfc23 commit 75959d4

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

scripts/Kconfig.include

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,8 @@ ld-option = $(success,$(LD) -v $(1))
3535
$(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found)
3636
$(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found)
3737

38+
# Fail if the linker is gold as it's not capable of linking the kernel proper
39+
$(error-if,$(success, $(LD) -v | grep -q gold), gold linker '$(LD)' not supported)
40+
3841
# gcc version including patch level
3942
gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC))

0 commit comments

Comments
 (0)