Skip to content

Commit 7934fdc

Browse files
mwajdeczrodrigovivi
authored andcommitted
drm/xe/configfs: Don't touch survivability_mode on fini
This is a user controlled configfs attribute, we should not modify that outside the configfs attr.store() implementation. Fixes: bc417e5 ("drm/xe: Enable configfs support for survivability mode") Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Riana Tauro <riana.tauro@intel.com> Reviewed-by: Stuart Summers <stuart.summers@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://lore.kernel.org/r/20250904103521.7130-1-michal.wajdeczko@intel.com (cherry picked from commit 079a5c8) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 76eeb9b commit 7934fdc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/xe/xe_survivability_mode.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
*
4242
* # echo 1 > /sys/kernel/config/xe/0000:03:00.0/survivability_mode
4343
*
44+
* It is the responsibility of the user to clear the mode once firmware flash is complete.
45+
*
4446
* Refer :ref:`xe_configfs` for more details on how to use configfs
4547
*
4648
* Survivability mode is indicated by the below admin-only readable sysfs which provides additional
@@ -147,7 +149,6 @@ static void xe_survivability_mode_fini(void *arg)
147149
struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
148150
struct device *dev = &pdev->dev;
149151

150-
xe_configfs_clear_survivability_mode(pdev);
151152
sysfs_remove_file(&dev->kobj, &dev_attr_survivability_mode.attr);
152153
}
153154

0 commit comments

Comments
 (0)