Skip to content

Commit 7de4840

Browse files
Doug Bergerdavem330
authored andcommitted
net: bcmgenet: don't set phydev->link from MAC
When commit 28b2e0d ("net: phy: remove parameter new_link from phy_mac_interrupt()") removed the new_link parameter it set the phydev->link state from the MAC before invoking phy_mac_interrupt(). However, once commit 88d6272 ("net: phy: avoid unneeded MDIO reads in genphy_read_status") was added this initialization prevents the proper determination of the connection parameters by the function genphy_read_status(). This commit removes that initialization to restore the proper functionality. Fixes: 88d6272 ("net: phy: avoid unneeded MDIO reads in genphy_read_status") Signed-off-by: Doug Berger <opendmb@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 0cc76d2 commit 7de4840

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/net/ethernet/broadcom/genet/bcmgenet.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2612,10 +2612,8 @@ static void bcmgenet_irq_task(struct work_struct *work)
26122612
spin_unlock_irq(&priv->lock);
26132613

26142614
/* Link UP/DOWN event */
2615-
if (status & UMAC_IRQ_LINK_EVENT) {
2616-
priv->dev->phydev->link = !!(status & UMAC_IRQ_LINK_UP);
2615+
if (status & UMAC_IRQ_LINK_EVENT)
26172616
phy_mac_interrupt(priv->dev->phydev);
2618-
}
26192617
}
26202618

26212619
/* bcmgenet_isr1: handle Rx and Tx priority queues */

0 commit comments

Comments
 (0)