xfs: fix a memory leak

Darrick J. Wong · Chandan Babu R · commit 80d3d33cdf4b · 2024-07-29T09:25:01.000+05:30
kmemleak reported that we don't free the parent pointer names here if we found corruption. Fixes: 0d29a20 ("xfs: scrub parent pointers") Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
diff --git a/fs/xfs/scrub/parent.c b/fs/xfs/scrub/parent.c
@@ -799,7 +799,7 @@ xchk_parent_pptr(
 	}
 
 	if (pp->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
-		goto out_pp;
+		goto out_names;
 
 	/*
 	 * Complain if the number of parent pointers doesn't match the link

Original file line number	Diff line number	Diff line change
`@@ -799,7 +799,7 @@ xchk_parent_pptr(`
`799`	`799`	`}`
`800`	`800`
`801`	`801`	`if (pp->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)`
`802`		`- goto out_pp;`
	`802`	`+ goto out_names;`
`803`	`803`
`804`	`804`	`/*`
`805`	`805`	`* Complain if the number of parent pointers doesn't match the link`