Skip to content

Commit 828c0aa

Browse files
vijendarmukundabroonie
authored andcommitted
ASoC: amd: ps: use switch statements for acp pci revision id check
Use switch statements for acp pci revision id check in SoundWire dma irq handling. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com> Link: https://patch.msgid.link/20250213103652.1082203-1-Vijendar.Mukunda@amd.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent f22ba35 commit 828c0aa

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

sound/soc/amd/ps/pci-ps.c

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,21 @@ static short int check_and_handle_sdw_dma_irq(struct acp63_dev_data *adata, u32
111111
stream_id = ACP63_SDW0_AUDIO2_RX;
112112
break;
113113
}
114-
if (adata->acp_rev >= ACP70_PCI_REV)
115-
adata->acp70_sdw0_dma_intr_stat[stream_id] = 1;
116-
else
114+
switch (adata->acp_rev) {
115+
case ACP63_PCI_REV:
117116
adata->acp63_sdw0_dma_intr_stat[stream_id] = 1;
118-
117+
break;
118+
case ACP70_PCI_REV:
119+
case ACP71_PCI_REV:
120+
adata->acp70_sdw0_dma_intr_stat[stream_id] = 1;
121+
break;
122+
}
119123
sdw_dma_irq_flag = 1;
120124
}
121125
}
122126
}
123-
if (adata->acp_rev == ACP63_PCI_REV) {
127+
switch (adata->acp_rev) {
128+
case ACP63_PCI_REV:
124129
if (ext_intr_stat1 & ACP63_P1_AUDIO1_RX_THRESHOLD) {
125130
writel(ACP63_P1_AUDIO1_RX_THRESHOLD,
126131
adata->acp63_base + ACP_EXTERNAL_INTR_STAT1);
@@ -133,7 +138,9 @@ static short int check_and_handle_sdw_dma_irq(struct acp63_dev_data *adata, u32
133138
adata->acp63_sdw1_dma_intr_stat[ACP63_SDW1_AUDIO1_TX] = 1;
134139
sdw_dma_irq_flag = 1;
135140
}
136-
} else {
141+
break;
142+
case ACP70_PCI_REV:
143+
case ACP71_PCI_REV:
137144
if (ext_intr_stat1 & ACP70_P1_SDW_DMA_IRQ_MASK) {
138145
for (index = ACP70_P1_AUDIO2_RX_THRESHOLD;
139146
index <= ACP70_P1_AUDIO0_TX_THRESHOLD; index++) {
@@ -166,6 +173,7 @@ static short int check_and_handle_sdw_dma_irq(struct acp63_dev_data *adata, u32
166173
}
167174
}
168175
}
176+
break;
169177
}
170178
return sdw_dma_irq_flag;
171179
}

0 commit comments

Comments
 (0)