scsi: fnic: Propagate SCSI error code from fnic_scsi_drv_init()

Arun Easi · martinkpetersen · commit 8697934682f1 · 2025-01-10T18:24:25.000-05:00
Propagate scsi_add_host() error instead of returning -1. Suggested-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Signed-off-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250110091956.17749-1-kartilak@cisco.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
@@ -637,7 +637,7 @@ static int fnic_scsi_drv_init(struct fnic *fnic)
 	err = scsi_add_host(fnic->host, &pdev->dev);
 	if (err) {
 		dev_err(&fnic->pdev->dev, "fnic: scsi add host failed: aborting\n");
-		return -1;
+		return err;
 	}
 	fc_host_maxframe_size(fnic->host) = iport->max_payload_size;
 	fc_host_dev_loss_tmo(fnic->host) =

Original file line number	Diff line number	Diff line change
`@@ -637,7 +637,7 @@ static int fnic_scsi_drv_init(struct fnic *fnic)`
`637`	`637`	`err = scsi_add_host(fnic->host, &pdev->dev);`
`638`	`638`	`if (err) {`
`639`	`639`	`dev_err(&fnic->pdev->dev, "fnic: scsi add host failed: aborting\n");`
`640`		`- return -1;`
	`640`	`+ return err;`
`641`	`641`	`}`
`642`	`642`	`fc_host_maxframe_size(fnic->host) = iport->max_payload_size;`
`643`	`643`	`fc_host_dev_loss_tmo(fnic->host) =`