Skip to content

Commit 8e27c2a

Browse files
committed
gpio: exar: switch to a simpler IDA interface
We don't need to specify any ranges when allocating IDs so we can switch to ida_alloc() and ida_free() instead of the ida_simple_ counterparts. ida_simple_get(ida, 0, 0, gfp) is equivalent to ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID larger than INT_MAX. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent 26ced45 commit 8e27c2a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpio/gpio-exar.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
149149

150150
mutex_init(&exar_gpio->lock);
151151

152-
index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);
152+
index = ida_alloc(&ida_index, GFP_KERNEL);
153153
if (index < 0) {
154154
ret = index;
155155
goto err_mutex_destroy;
@@ -179,7 +179,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
179179
return 0;
180180

181181
err_destroy:
182-
ida_simple_remove(&ida_index, index);
182+
ida_free(&ida_index, index);
183183
err_mutex_destroy:
184184
mutex_destroy(&exar_gpio->lock);
185185
return ret;
@@ -189,7 +189,7 @@ static int gpio_exar_remove(struct platform_device *pdev)
189189
{
190190
struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev);
191191

192-
ida_simple_remove(&ida_index, exar_gpio->index);
192+
ida_free(&ida_index, exar_gpio->index);
193193
mutex_destroy(&exar_gpio->lock);
194194

195195
return 0;

0 commit comments

Comments
 (0)