Skip to content

Commit 91f26cb

Browse files
committed
genirq/cpuhotplug: Do not migrated shutdown irqs
Interrupts, which are shut down are tried to be migrated as well. That's pointless because the interrupt cannot fire and the next startup will move it to the proper place anyway. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Keith Busch <keith.busch@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Christoph Hellwig <hch@lst.de> Link: http://lkml.kernel.org/r/20170619235445.447550992@linutronix.de
1 parent e8a7035 commit 91f26cb

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

kernel/irq/cpuhotplug.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,15 @@ static bool migrate_one_irq(struct irq_desc *desc)
3333
}
3434

3535
/*
36-
* If this is a per-CPU interrupt, or the affinity does not
37-
* include this CPU, then we have nothing to do.
36+
* No move required, if:
37+
* - Interrupt is per cpu
38+
* - Interrupt is not started
39+
* - Affinity mask does not include this CPU.
40+
*
41+
* Note: Do not check desc->action as this might be a chained
42+
* interrupt.
3843
*/
39-
if (irqd_is_per_cpu(d) ||
44+
if (irqd_is_per_cpu(d) || !irqd_is_started(d) ||
4045
!cpumask_test_cpu(smp_processor_id(), affinity))
4146
return false;
4247

0 commit comments

Comments
 (0)