Skip to content

Commit 936fb51

Browse files
Michael Karcherandreas-gaisler
authored andcommitted
sparc: fix accurate exception reporting in copy_{from,to}_user for M7
The referenced commit introduced exception handlers on user-space memory references in copy_from_user and copy_to_user. These handlers return from the respective function and calculate the remaining bytes left to copy using the current register contents. This commit fixes a couple of bad calculations. This will fix the return value of copy_from_user and copy_to_user in the faulting case. The behaviour of memcpy stays unchanged. Fixes: 34060b8 ("arch/sparc: Add accurate exception reporting in M7memcpy") Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> # on Oracle SPARC S7 Tested-by: Tony Rodriguez <unixpro1970@gmail.com> # S7, see https://lore.kernel.org/r/98564e2e68df2dda0e00c67a75c7f7dfedb33c7e.camel@physik.fu-berlin.de Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> Reviewed-by: Andreas Larsson <andreas@gaisler.com> Link: https://lore.kernel.org/r/20250905-memcpy_series-v4-5-1ca72dda195b@mkarcher.dialup.fu-berlin.de Signed-off-by: Andreas Larsson <andreas@gaisler.com>
1 parent 5a746c1 commit 936fb51

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

arch/sparc/lib/M7memcpy.S

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -696,16 +696,16 @@ FUNC_NAME:
696696
EX_LD_FP(LOAD(ldd, %o4+40, %f26), memcpy_retl_o2_plus_o5_plus_40)
697697
faligndata %f24, %f26, %f10
698698
EX_ST_FP(STORE(std, %f6, %o0+24), memcpy_retl_o2_plus_o5_plus_40)
699-
EX_LD_FP(LOAD(ldd, %o4+48, %f28), memcpy_retl_o2_plus_o5_plus_40)
699+
EX_LD_FP(LOAD(ldd, %o4+48, %f28), memcpy_retl_o2_plus_o5_plus_32)
700700
faligndata %f26, %f28, %f12
701-
EX_ST_FP(STORE(std, %f8, %o0+32), memcpy_retl_o2_plus_o5_plus_40)
701+
EX_ST_FP(STORE(std, %f8, %o0+32), memcpy_retl_o2_plus_o5_plus_32)
702702
add %o4, 64, %o4
703-
EX_LD_FP(LOAD(ldd, %o4-8, %f30), memcpy_retl_o2_plus_o5_plus_40)
703+
EX_LD_FP(LOAD(ldd, %o4-8, %f30), memcpy_retl_o2_plus_o5_plus_24)
704704
faligndata %f28, %f30, %f14
705-
EX_ST_FP(STORE(std, %f10, %o0+40), memcpy_retl_o2_plus_o5_plus_40)
706-
EX_ST_FP(STORE(std, %f12, %o0+48), memcpy_retl_o2_plus_o5_plus_40)
705+
EX_ST_FP(STORE(std, %f10, %o0+40), memcpy_retl_o2_plus_o5_plus_24)
706+
EX_ST_FP(STORE(std, %f12, %o0+48), memcpy_retl_o2_plus_o5_plus_16)
707707
add %o0, 64, %o0
708-
EX_ST_FP(STORE(std, %f14, %o0-8), memcpy_retl_o2_plus_o5_plus_40)
708+
EX_ST_FP(STORE(std, %f14, %o0-8), memcpy_retl_o2_plus_o5_plus_8)
709709
fsrc2 %f30, %f14
710710
bgu,pt %xcc, .Lunalign_sloop
711711
prefetch [%o4 + (8 * BLOCK_SIZE)], 20
@@ -728,7 +728,7 @@ FUNC_NAME:
728728
add %o4, 8, %o4
729729
faligndata %f0, %f2, %f16
730730
subcc %o5, 8, %o5
731-
EX_ST_FP(STORE(std, %f16, %o0), memcpy_retl_o2_plus_o5)
731+
EX_ST_FP(STORE(std, %f16, %o0), memcpy_retl_o2_plus_o5_plus_8)
732732
fsrc2 %f2, %f0
733733
bgu,pt %xcc, .Lunalign_by8
734734
add %o0, 8, %o0
@@ -772,7 +772,7 @@ FUNC_NAME:
772772
subcc %o5, 0x20, %o5
773773
EX_ST(STORE(stx, %o3, %o0 + 0x00), memcpy_retl_o2_plus_o5_plus_32)
774774
EX_ST(STORE(stx, %g2, %o0 + 0x08), memcpy_retl_o2_plus_o5_plus_24)
775-
EX_ST(STORE(stx, %g7, %o0 + 0x10), memcpy_retl_o2_plus_o5_plus_24)
775+
EX_ST(STORE(stx, %g7, %o0 + 0x10), memcpy_retl_o2_plus_o5_plus_16)
776776
EX_ST(STORE(stx, %o4, %o0 + 0x18), memcpy_retl_o2_plus_o5_plus_8)
777777
bne,pt %xcc, 1b
778778
add %o0, 0x20, %o0
@@ -804,12 +804,12 @@ FUNC_NAME:
804804
brz,pt %o3, 2f
805805
sub %o2, %o3, %o2
806806

807-
1: EX_LD(LOAD(ldub, %o1 + 0x00, %g2), memcpy_retl_o2_plus_g1)
807+
1: EX_LD(LOAD(ldub, %o1 + 0x00, %g2), memcpy_retl_o2_plus_o3)
808808
add %o1, 1, %o1
809809
subcc %o3, 1, %o3
810810
add %o0, 1, %o0
811811
bne,pt %xcc, 1b
812-
EX_ST(STORE(stb, %g2, %o0 - 0x01), memcpy_retl_o2_plus_g1_plus_1)
812+
EX_ST(STORE(stb, %g2, %o0 - 0x01), memcpy_retl_o2_plus_o3_plus_1)
813813
2:
814814
and %o1, 0x7, %o3
815815
brz,pn %o3, .Lmedium_noprefetch_cp

arch/sparc/lib/Memcpy_utils.S

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,15 @@ ENTRY(memcpy_retl_o2_plus_63_8)
137137
ba,pt %xcc, __restore_asi
138138
add %o2, 8, %o0
139139
ENDPROC(memcpy_retl_o2_plus_63_8)
140+
ENTRY(memcpy_retl_o2_plus_o3)
141+
ba,pt %xcc, __restore_asi
142+
add %o2, %o3, %o0
143+
ENDPROC(memcpy_retl_o2_plus_o3)
144+
ENTRY(memcpy_retl_o2_plus_o3_plus_1)
145+
add %o3, 1, %o3
146+
ba,pt %xcc, __restore_asi
147+
add %o2, %o3, %o0
148+
ENDPROC(memcpy_retl_o2_plus_o3_plus_1)
140149
ENTRY(memcpy_retl_o2_plus_o5)
141150
ba,pt %xcc, __restore_asi
142151
add %o2, %o5, %o0

0 commit comments

Comments
 (0)