nvme: requeue namespace scan on missed AENs

Hannes Reinecke · Christoph Hellwig · commit 9546ad1a9bda · 2025-04-07T16:26:50.000+02:00
Scanning for namespaces can take some time, so if the target is
reconfigured while the scan is running we may miss a Attached Namespace
Attribute Changed AEN.

Check if the NVME_AER_NOTICE_NS_CHANGED bit is set once the scan has
finished, and requeue scanning to pick up any missed change.

Signed-off-by: Hannes Reinecke &lt;hare@kernel.org&gt;
Reviewed-by: Keith Busch &lt;kbusch@kernel.org&gt;
Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
@@ -4295,6 +4295,10 @@ static void nvme_scan_work(struct work_struct *work)
 			nvme_scan_ns_sequential(ctrl);
 	}
 	mutex_unlock(&ctrl->scan_lock);
+
+	/* Requeue if we have missed AENs */
+	if (test_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events))
+		nvme_queue_scan(ctrl);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -4295,6 +4295,10 @@ static void nvme_scan_work(struct work_struct *work)`
`4295`	`4295`	`nvme_scan_ns_sequential(ctrl);`
`4296`	`4296`	`}`
`4297`	`4297`	`mutex_unlock(&ctrl->scan_lock);`
	`4298`	`+`
	`4299`	`+ /* Requeue if we have missed AENs */`
	`4300`	`+ if (test_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events))`
	`4301`	`+ nvme_queue_scan(ctrl);`
`4298`	`4302`	`}`
`4299`	`4303`
`4300`	`4304`	`/*`