Skip to content

Commit 95c4751

Browse files
ebiggersherbertx
authored andcommitted
crypto: stm32 - use the new scatterwalk functions
Replace calls to the deprecated function scatterwalk_copychunks() with memcpy_from_scatterwalk(), memcpy_to_scatterwalk(), scatterwalk_skip(), or scatterwalk_start_at_pos() as appropriate. Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Maxime Méré <maxime.mere@foss.st.com> Cc: Thomas Bourgoin <thomas.bourgoin@foss.st.com> Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 323abf2 commit 95c4751

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

drivers/crypto/stm32/stm32-cryp.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ static void stm32_cryp_write_ccm_first_header(struct stm32_cryp *cryp)
666666

667667
written = min_t(size_t, AES_BLOCK_SIZE - len, alen);
668668

669-
scatterwalk_copychunks((char *)block + len, &cryp->in_walk, written, 0);
669+
memcpy_from_scatterwalk((char *)block + len, &cryp->in_walk, written);
670670

671671
writesl(cryp->regs + cryp->caps->din, block, AES_BLOCK_32);
672672

@@ -993,7 +993,7 @@ static int stm32_cryp_header_dma_start(struct stm32_cryp *cryp)
993993

994994
/* Advance scatterwalk to not DMA'ed data */
995995
align_size = ALIGN_DOWN(cryp->header_in, cryp->hw_blocksize);
996-
scatterwalk_copychunks(NULL, &cryp->in_walk, align_size, 2);
996+
scatterwalk_skip(&cryp->in_walk, align_size);
997997
cryp->header_in -= align_size;
998998

999999
ret = dma_submit_error(dmaengine_submit(tx_in));
@@ -1056,7 +1056,7 @@ static int stm32_cryp_dma_start(struct stm32_cryp *cryp)
10561056

10571057
/* Advance scatterwalk to not DMA'ed data */
10581058
align_size = ALIGN_DOWN(cryp->payload_in, cryp->hw_blocksize);
1059-
scatterwalk_copychunks(NULL, &cryp->in_walk, align_size, 2);
1059+
scatterwalk_skip(&cryp->in_walk, align_size);
10601060
cryp->payload_in -= align_size;
10611061

10621062
ret = dma_submit_error(dmaengine_submit(tx_in));
@@ -1067,7 +1067,7 @@ static int stm32_cryp_dma_start(struct stm32_cryp *cryp)
10671067
dma_async_issue_pending(cryp->dma_lch_in);
10681068

10691069
/* Advance scatterwalk to not DMA'ed data */
1070-
scatterwalk_copychunks(NULL, &cryp->out_walk, align_size, 2);
1070+
scatterwalk_skip(&cryp->out_walk, align_size);
10711071
cryp->payload_out -= align_size;
10721072
ret = dma_submit_error(dmaengine_submit(tx_out));
10731073
if (ret < 0) {
@@ -1737,9 +1737,9 @@ static int stm32_cryp_prepare_req(struct skcipher_request *req,
17371737
out_sg = areq->dst;
17381738

17391739
scatterwalk_start(&cryp->in_walk, in_sg);
1740-
scatterwalk_start(&cryp->out_walk, out_sg);
17411740
/* In output, jump after assoc data */
1742-
scatterwalk_copychunks(NULL, &cryp->out_walk, cryp->areq->assoclen, 2);
1741+
scatterwalk_start_at_pos(&cryp->out_walk, out_sg,
1742+
areq->assoclen);
17431743

17441744
ret = stm32_cryp_hw_init(cryp);
17451745
if (ret)
@@ -1873,12 +1873,12 @@ static int stm32_cryp_read_auth_tag(struct stm32_cryp *cryp)
18731873

18741874
/* Get and write tag */
18751875
readsl(cryp->regs + cryp->caps->dout, out_tag, AES_BLOCK_32);
1876-
scatterwalk_copychunks(out_tag, &cryp->out_walk, cryp->authsize, 1);
1876+
memcpy_to_scatterwalk(&cryp->out_walk, out_tag, cryp->authsize);
18771877
} else {
18781878
/* Get and check tag */
18791879
u32 in_tag[AES_BLOCK_32], out_tag[AES_BLOCK_32];
18801880

1881-
scatterwalk_copychunks(in_tag, &cryp->in_walk, cryp->authsize, 0);
1881+
memcpy_from_scatterwalk(in_tag, &cryp->in_walk, cryp->authsize);
18821882
readsl(cryp->regs + cryp->caps->dout, out_tag, AES_BLOCK_32);
18831883

18841884
if (crypto_memneq(in_tag, out_tag, cryp->authsize))
@@ -1923,8 +1923,8 @@ static void stm32_cryp_irq_read_data(struct stm32_cryp *cryp)
19231923
u32 block[AES_BLOCK_32];
19241924

19251925
readsl(cryp->regs + cryp->caps->dout, block, cryp->hw_blocksize / sizeof(u32));
1926-
scatterwalk_copychunks(block, &cryp->out_walk, min_t(size_t, cryp->hw_blocksize,
1927-
cryp->payload_out), 1);
1926+
memcpy_to_scatterwalk(&cryp->out_walk, block, min_t(size_t, cryp->hw_blocksize,
1927+
cryp->payload_out));
19281928
cryp->payload_out -= min_t(size_t, cryp->hw_blocksize,
19291929
cryp->payload_out);
19301930
}
@@ -1933,8 +1933,8 @@ static void stm32_cryp_irq_write_block(struct stm32_cryp *cryp)
19331933
{
19341934
u32 block[AES_BLOCK_32] = {0};
19351935

1936-
scatterwalk_copychunks(block, &cryp->in_walk, min_t(size_t, cryp->hw_blocksize,
1937-
cryp->payload_in), 0);
1936+
memcpy_from_scatterwalk(block, &cryp->in_walk, min_t(size_t, cryp->hw_blocksize,
1937+
cryp->payload_in));
19381938
writesl(cryp->regs + cryp->caps->din, block, cryp->hw_blocksize / sizeof(u32));
19391939
cryp->payload_in -= min_t(size_t, cryp->hw_blocksize, cryp->payload_in);
19401940
}
@@ -1981,8 +1981,8 @@ static void stm32_cryp_irq_write_gcm_padded_data(struct stm32_cryp *cryp)
19811981
*/
19821982
readsl(cryp->regs + cryp->caps->dout, block, cryp->hw_blocksize / sizeof(u32));
19831983

1984-
scatterwalk_copychunks(block, &cryp->out_walk, min_t(size_t, cryp->hw_blocksize,
1985-
cryp->payload_out), 1);
1984+
memcpy_to_scatterwalk(&cryp->out_walk, block, min_t(size_t, cryp->hw_blocksize,
1985+
cryp->payload_out));
19861986
cryp->payload_out -= min_t(size_t, cryp->hw_blocksize,
19871987
cryp->payload_out);
19881988

@@ -2079,8 +2079,8 @@ static void stm32_cryp_irq_write_ccm_padded_data(struct stm32_cryp *cryp)
20792079
*/
20802080
readsl(cryp->regs + cryp->caps->dout, block, cryp->hw_blocksize / sizeof(u32));
20812081

2082-
scatterwalk_copychunks(block, &cryp->out_walk, min_t(size_t, cryp->hw_blocksize,
2083-
cryp->payload_out), 1);
2082+
memcpy_to_scatterwalk(&cryp->out_walk, block, min_t(size_t, cryp->hw_blocksize,
2083+
cryp->payload_out));
20842084
cryp->payload_out -= min_t(size_t, cryp->hw_blocksize, cryp->payload_out);
20852085

20862086
/* d) Load again CRYP_CSGCMCCMxR */
@@ -2161,7 +2161,7 @@ static void stm32_cryp_irq_write_gcmccm_header(struct stm32_cryp *cryp)
21612161

21622162
written = min_t(size_t, AES_BLOCK_SIZE, cryp->header_in);
21632163

2164-
scatterwalk_copychunks(block, &cryp->in_walk, written, 0);
2164+
memcpy_from_scatterwalk(block, &cryp->in_walk, written);
21652165

21662166
writesl(cryp->regs + cryp->caps->din, block, AES_BLOCK_32);
21672167

0 commit comments

Comments
 (0)