Skip to content

Commit 964f231

Browse files
author
Christoph Hellwig
committed
iommu/intel: small map_page cleanup
Pass the page + offset to the low-level __iommu_map_single helper (which gets renamed to fit the new calling conventions) as both callers have the page at hand. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent b3aa14f commit 964f231

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/iommu/intel-iommu.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3597,9 +3597,11 @@ static int iommu_no_mapping(struct device *dev)
35973597
return 0;
35983598
}
35993599

3600-
static dma_addr_t __intel_map_single(struct device *dev, phys_addr_t paddr,
3601-
size_t size, int dir, u64 dma_mask)
3600+
static dma_addr_t __intel_map_page(struct device *dev, struct page *page,
3601+
unsigned long offset, size_t size, int dir,
3602+
u64 dma_mask)
36023603
{
3604+
phys_addr_t paddr = page_to_phys(page) + offset;
36033605
struct dmar_domain *domain;
36043606
phys_addr_t start_paddr;
36053607
unsigned long iova_pfn;
@@ -3661,8 +3663,7 @@ static dma_addr_t intel_map_page(struct device *dev, struct page *page,
36613663
enum dma_data_direction dir,
36623664
unsigned long attrs)
36633665
{
3664-
return __intel_map_single(dev, page_to_phys(page) + offset, size,
3665-
dir, *dev->dma_mask);
3666+
return __intel_map_page(dev, page, offset, size, dir, *dev->dma_mask);
36663667
}
36673668

36683669
static void intel_unmap(struct device *dev, dma_addr_t dev_addr, size_t size)
@@ -3753,9 +3754,8 @@ static void *intel_alloc_coherent(struct device *dev, size_t size,
37533754
return NULL;
37543755
memset(page_address(page), 0, size);
37553756

3756-
*dma_handle = __intel_map_single(dev, page_to_phys(page), size,
3757-
DMA_BIDIRECTIONAL,
3758-
dev->coherent_dma_mask);
3757+
*dma_handle = __intel_map_page(dev, page, 0, size, DMA_BIDIRECTIONAL,
3758+
dev->coherent_dma_mask);
37593759
if (*dma_handle)
37603760
return page_address(page);
37613761
if (!dma_release_from_contiguous(dev, page, size >> PAGE_SHIFT))

0 commit comments

Comments
 (0)