Skip to content

Commit 98c69fc

Browse files
committed
Merge series "ASoC: SOF/Intel: fix and remove Sparse warnings" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:
We updated our SOF CI settings last week (see below) to use more options for Sparse, and sure enough it detected one nasty single-character bug in one of my previous patches, along with more trivial issues with string/integer sizes and signed/unsigned confusions. export ARCH=x86_64 export CF="-Wsparse-error -Wsparse-all -Wno-bitwise-pointer -Wno-pointer-arith -Wno-typesign -Wnoshadow" make -k sound/soc/sof/ C=2 make -k sound/soc/intel/common/ C=2 make -k sound/soc/intel/boards/ C=2 make -k drivers/soundwire/ C=2 Pierre-Louis Bossart (9): ASoC: SOF: Intel: hda: fix index used in inner loop ASoC: Intel: sof_rt5682: shrink platform_id names below 20 characters ASoC: Intel: sof_cs42l42: shrink platform id below 20 characters ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20 characters ASoC: Intel: glk_rt5682_max98357a: shrink platform_id below 20 characters ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters ASoC: Intel: sof_sdw: fix signed/unsigned warning ASoC: Intel: soc-acpi: add ull suffix for SoundWire _ADR values sound/soc/intel/boards/bxt_da7219_max98357a.c | 12 +++--- sound/soc/intel/boards/glk_rt5682_max98357a.c | 4 +- sound/soc/intel/boards/kbl_da7219_max98357a.c | 4 +- sound/soc/intel/boards/sof_cs42l42.c | 2 +- sound/soc/intel/boards/sof_da7219_max98373.c | 8 ++-- sound/soc/intel/boards/sof_rt5682.c | 20 +++++----- sound/soc/intel/boards/sof_sdw.c | 2 +- .../intel/common/soc-acpi-intel-adl-match.c | 28 +++++++------- .../intel/common/soc-acpi-intel-bxt-match.c | 2 +- .../intel/common/soc-acpi-intel-cml-match.c | 22 +++++------ .../intel/common/soc-acpi-intel-cnl-match.c | 2 +- .../intel/common/soc-acpi-intel-glk-match.c | 6 +-- .../intel/common/soc-acpi-intel-icl-match.c | 12 +++--- .../intel/common/soc-acpi-intel-jsl-match.c | 6 +-- .../intel/common/soc-acpi-intel-kbl-match.c | 2 +- .../intel/common/soc-acpi-intel-tgl-match.c | 38 +++++++++---------- sound/soc/sof/intel/hda.c | 2 +- 17 files changed, 86 insertions(+), 86 deletions(-) -- 2.25.1
2 parents c9f2e3c + 24e46fb commit 98c69fc

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

sound/soc/intel/boards/bxt_da7219_max98357a.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -840,9 +840,9 @@ static int broxton_audio_probe(struct platform_device *pdev)
840840
}
841841

842842
static const struct platform_device_id bxt_board_ids[] = {
843-
{ .name = "bxt_da7219_max98357a" },
844-
{ .name = "glk_da7219_max98357a" },
845-
{ .name = "cml_da7219_max98357a" },
843+
{ .name = "bxt_da7219_mx98357a" },
844+
{ .name = "glk_da7219_mx98357a" },
845+
{ .name = "cml_da7219_mx98357a" },
846846
{ }
847847
};
848848

@@ -866,7 +866,7 @@ MODULE_AUTHOR("Naveen Manohar <naveen.m@intel.com>");
866866
MODULE_AUTHOR("Mac Chiang <mac.chiang@intel.com>");
867867
MODULE_AUTHOR("Brent Lu <brent.lu@intel.com>");
868868
MODULE_LICENSE("GPL v2");
869-
MODULE_ALIAS("platform:bxt_da7219_max98357a");
870-
MODULE_ALIAS("platform:glk_da7219_max98357a");
871-
MODULE_ALIAS("platform:cml_da7219_max98357a");
869+
MODULE_ALIAS("platform:bxt_da7219_mx98357a");
870+
MODULE_ALIAS("platform:glk_da7219_mx98357a");
871+
MODULE_ALIAS("platform:cml_da7219_mx98357a");
872872
MODULE_IMPORT_NS(SND_SOC_INTEL_HDA_DSP_COMMON);

sound/soc/intel/boards/sof_cs42l42.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ static int sof_audio_probe(struct platform_device *pdev)
480480

481481
static const struct platform_device_id board_ids[] = {
482482
{
483-
.name = "glk_cs4242_max98357a",
483+
.name = "glk_cs4242_mx98357a",
484484
.driver_data = (kernel_ulong_t)(SOF_CS42L42_SSP_CODEC(2) |
485485
SOF_SPEAKER_AMP_PRESENT |
486486
SOF_MAX98357A_SPEAKER_AMP_PRESENT |

sound/soc/intel/common/soc-acpi-intel-bxt-match.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_bxt_machines[] = {
5656
},
5757
{
5858
.id = "DLGS7219",
59-
.drv_name = "bxt_da7219_max98357a",
59+
.drv_name = "bxt_da7219_mx98357a",
6060
.fw_filename = "intel/dsp_fw_bxtn.bin",
6161
.machine_quirk = snd_soc_acpi_codec_list,
6262
.quirk_data = &bxt_codecs,

sound/soc/intel/common/soc-acpi-intel-cml-match.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_machines[] = {
6767
},
6868
{
6969
.id = "DLGS7219",
70-
.drv_name = "cml_da7219_max98357a",
70+
.drv_name = "cml_da7219_mx98357a",
7171
.machine_quirk = snd_soc_acpi_codec_list,
7272
.quirk_data = &max98357a_spk_codecs,
7373
.sof_fw_filename = "sof-cml.ri",

sound/soc/intel/common/soc-acpi-intel-glk-match.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
2424
},
2525
{
2626
.id = "DLGS7219",
27-
.drv_name = "glk_da7219_max98357a",
27+
.drv_name = "glk_da7219_mx98357a",
2828
.fw_filename = "intel/dsp_fw_glk.bin",
2929
.machine_quirk = snd_soc_acpi_codec_list,
3030
.quirk_data = &glk_codecs,
@@ -42,7 +42,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
4242
},
4343
{
4444
.id = "10134242",
45-
.drv_name = "glk_cs4242_max98357a",
45+
.drv_name = "glk_cs4242_mx98357a",
4646
.fw_filename = "intel/dsp_fw_glk.bin",
4747
.machine_quirk = snd_soc_acpi_codec_list,
4848
.quirk_data = &glk_codecs,

sound/soc/sof/intel/hda.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1069,7 +1069,7 @@ static bool link_slaves_found(struct snd_sof_dev *sdev,
10691069

10701070
/* find out how many identical parts are expected */
10711071
for (k = 0; k < link->num_adr; k++) {
1072-
u64 adr2 = link->adr_d[i].adr;
1072+
u64 adr2 = link->adr_d[k].adr;
10731073
unsigned int part_id2, link_id2, mfg_id2;
10741074

10751075
mfg_id2 = SDW_MFG_ID(adr2);

0 commit comments

Comments
 (0)