Skip to content

Commit a0dcd1f

Browse files
geertubroonie
authored andcommitted
spi: renesas,sh-msiof: Miscellaneous improvements
Make "clocks" and "power-domains" required everywhere. Make "resets" required on R-Car Gen2 and newer (i.e. all but SH-Mobile). Update the example to match reality: - Use interrupt binding definitions instead of hardcoded numbers, - Convert to new-style CPG/MSSR bindings, - Add missing "power-domains" and "resets" properties. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/052af97ecbaa9ba6e0d406883dd3389fa397579a.1678891999.git.geert+renesas@glider.be Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 864f051 commit a0dcd1f

File tree

1 file changed

+19
-4
lines changed

1 file changed

+19
-4
lines changed

Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,23 +149,38 @@ required:
149149
- compatible
150150
- reg
151151
- interrupts
152+
- clocks
153+
- power-domains
152154
- '#address-cells'
153155
- '#size-cells'
154156

157+
if:
158+
not:
159+
properties:
160+
compatible:
161+
contains:
162+
const: renesas,sh-mobile-msiof
163+
then:
164+
required:
165+
- resets
166+
155167
unevaluatedProperties: false
156168

157169
examples:
158170
- |
159-
#include <dt-bindings/clock/r8a7791-clock.h>
160-
#include <dt-bindings/interrupt-controller/irq.h>
171+
#include <dt-bindings/clock/r8a7791-cpg-mssr.h>
172+
#include <dt-bindings/interrupt-controller/arm-gic.h>
173+
#include <dt-bindings/power/r8a7791-sysc.h>
161174
162175
msiof0: spi@e6e20000 {
163176
compatible = "renesas,msiof-r8a7791", "renesas,rcar-gen2-msiof";
164177
reg = <0xe6e20000 0x0064>;
165-
interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
166-
clocks = <&mstp0_clks R8A7791_CLK_MSIOF0>;
178+
interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
179+
clocks = <&cpg CPG_MOD 000>;
167180
dmas = <&dmac0 0x51>, <&dmac0 0x52>;
168181
dma-names = "tx", "rx";
182+
power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
183+
resets = <&cpg 0>;
169184
#address-cells = <1>;
170185
#size-cells = <0>;
171186
};

0 commit comments

Comments
 (0)