Skip to content

Commit a1cd2b1

Browse files
Srivatsa S. BhatIngo Molnar
authored andcommitted
cpusets: Remove/update outdated comments
cpuset_track_online_cpus() is no longer present. So remove the outdated comment and replace it with reference to cpuset_update_active_cpus() which is its equivalent. Also, we don't lack memory hot-unplug anymore. And David Rientjes pointed out how it is dealt with. So update that comment as well. Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20120524141700.3692.98192.stgit@srivatsabhat.in.ibm.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 7ddf96b commit a1cd2b1

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

kernel/cpuset.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2034,9 +2034,8 @@ static struct cpuset *cpuset_next(struct list_head *queue)
20342034
* before dropping down to the next. It always processes a node before
20352035
* any of its children.
20362036
*
2037-
* For now, since we lack memory hot unplug, we'll never see a cpuset
2038-
* that has tasks along with an empty 'mems'. But if we did see such
2039-
* a cpuset, we'd handle it just like we do if its 'cpus' was empty.
2037+
* In the case of memory hot-unplug, it will remove nodes from N_HIGH_MEMORY
2038+
* if all present pages from a node are offlined.
20402039
*/
20412040
static void
20422041
scan_cpusets_upon_hotplug(struct cpuset *root, enum hotplug_event event)
@@ -2137,7 +2136,7 @@ void cpuset_update_active_cpus(bool cpu_online)
21372136
/*
21382137
* Keep top_cpuset.mems_allowed tracking node_states[N_HIGH_MEMORY].
21392138
* Call this routine anytime after node_states[N_HIGH_MEMORY] changes.
2140-
* See also the previous routine cpuset_track_online_cpus().
2139+
* See cpuset_update_active_cpus() for CPU hotplug handling.
21412140
*/
21422141
static int cpuset_track_online_nodes(struct notifier_block *self,
21432142
unsigned long action, void *arg)

0 commit comments

Comments
 (0)