Skip to content

Commit a2ec617

Browse files
Sudarsana Kallurudavem330
authored andcommitted
qede: Add support for link
This adds basic link functionality to qede - driver still doesn't provide users with an API to change any link property, but it does request qed to initialize the link using default configuration, and registers a callback that allows it to get link notifications. This patch adds the ability of the driver to set the carrier as active and to enable traffic as a result of async. link notifications. Following this patch, driver should be capable of running traffic. Signed-off-by: Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com> Signed-off-by: Ariel Elior <Ariel.Elior@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent cc875c2 commit a2ec617

File tree

1 file changed

+47
-0
lines changed

1 file changed

+47
-0
lines changed

drivers/net/ethernet/qlogic/qede/qede_main.c

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ static int qede_probe(struct pci_dev *pdev, const struct pci_device_id *id);
8787
static void qede_remove(struct pci_dev *pdev);
8888
static int qede_alloc_rx_buffer(struct qede_dev *edev,
8989
struct qede_rx_queue *rxq);
90+
static void qede_link_update(void *dev, struct qed_link_output *link);
9091

9192
static struct pci_driver qede_pci_driver = {
9293
.name = "qede",
@@ -95,6 +96,12 @@ static struct pci_driver qede_pci_driver = {
9596
.remove = qede_remove,
9697
};
9798

99+
static struct qed_eth_cb_ops qede_ll_ops = {
100+
{
101+
.link_update = qede_link_update,
102+
},
103+
};
104+
98105
static int qede_netdev_event(struct notifier_block *this, unsigned long event,
99106
void *ptr)
100107
{
@@ -1304,6 +1311,8 @@ static int __qede_probe(struct pci_dev *pdev, u32 dp_module, u8 dp_level,
13041311

13051312
edev->ops->common->set_id(cdev, edev->ndev->name, DRV_MODULE_VERSION);
13061313

1314+
edev->ops->register_ops(cdev, &qede_ll_ops, edev);
1315+
13071316
INIT_DELAYED_WORK(&edev->sp_task, qede_sp_task);
13081317
mutex_init(&edev->qede_lock);
13091318

@@ -2099,6 +2108,7 @@ enum qede_unload_mode {
20992108

21002109
static void qede_unload(struct qede_dev *edev, enum qede_unload_mode mode)
21012110
{
2111+
struct qed_link_params link_params;
21022112
int rc;
21032113

21042114
DP_INFO(edev, "Starting qede unload\n");
@@ -2110,6 +2120,10 @@ static void qede_unload(struct qede_dev *edev, enum qede_unload_mode mode)
21102120
netif_tx_disable(edev->ndev);
21112121
netif_carrier_off(edev->ndev);
21122122

2123+
/* Reset the link */
2124+
memset(&link_params, 0, sizeof(link_params));
2125+
link_params.link_up = false;
2126+
edev->ops->common->set_link(edev->cdev, &link_params);
21132127
rc = qede_stop_queues(edev);
21142128
if (rc) {
21152129
qede_sync_free_irqs(edev);
@@ -2140,6 +2154,8 @@ enum qede_load_mode {
21402154

21412155
static int qede_load(struct qede_dev *edev, enum qede_load_mode mode)
21422156
{
2157+
struct qed_link_params link_params;
2158+
struct qed_link_output link_output;
21432159
int rc;
21442160

21452161
DP_INFO(edev, "Starting qede load\n");
@@ -2183,6 +2199,17 @@ static int qede_load(struct qede_dev *edev, enum qede_load_mode mode)
21832199
mutex_lock(&edev->qede_lock);
21842200
edev->state = QEDE_STATE_OPEN;
21852201
mutex_unlock(&edev->qede_lock);
2202+
2203+
/* Ask for link-up using current configuration */
2204+
memset(&link_params, 0, sizeof(link_params));
2205+
link_params.link_up = true;
2206+
edev->ops->common->set_link(edev->cdev, &link_params);
2207+
2208+
/* Query whether link is already-up */
2209+
memset(&link_output, 0, sizeof(link_output));
2210+
edev->ops->common->get_link(edev->cdev, &link_output);
2211+
qede_link_update(edev, &link_output);
2212+
21862213
DP_INFO(edev, "Ending successfully qede load\n");
21872214

21882215
return 0;
@@ -2223,6 +2250,26 @@ static int qede_close(struct net_device *ndev)
22232250
return 0;
22242251
}
22252252

2253+
static void qede_link_update(void *dev, struct qed_link_output *link)
2254+
{
2255+
struct qede_dev *edev = dev;
2256+
2257+
if (!netif_running(edev->ndev)) {
2258+
DP_VERBOSE(edev, NETIF_MSG_LINK, "Interface is not running\n");
2259+
return;
2260+
}
2261+
2262+
if (link->link_up) {
2263+
DP_NOTICE(edev, "Link is up\n");
2264+
netif_tx_start_all_queues(edev->ndev);
2265+
netif_carrier_on(edev->ndev);
2266+
} else {
2267+
DP_NOTICE(edev, "Link is down\n");
2268+
netif_tx_disable(edev->ndev);
2269+
netif_carrier_off(edev->ndev);
2270+
}
2271+
}
2272+
22262273
static int qede_set_mac_addr(struct net_device *ndev, void *p)
22272274
{
22282275
struct qede_dev *edev = netdev_priv(ndev);

0 commit comments

Comments
 (0)