Skip to content

Commit a3daf18

Browse files
drawocLyude
authored andcommitted
drm/nouveau: Improve message for missing firmware
This is inteded to address concerns that users might get cryptic error messages or a failure to boot if they set nouveau.config=NvGspRm=0 on the kernel command line and their gpu requires gsp (Ada or newer). With this patch, that configuration results in error messages like this: nouveau 0000:01:00.0: gsp: Failed to load required firmware for device. nouveau 0000:01:00.0: gsp ctor failed: -22 nouveau 0000:01:00.0: probe with driver nouveau failed with error -22 When nouveau fails to load like this, we still fall back to the generic framebuffer device, so users will still have limited graphical output. Signed-off-by: Mel Henning <mhenning@darkrefraction.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Link: https://lore.kernel.org/r/20250811213843.4294-4-mhenning@darkrefraction.com
1 parent 2e308a9 commit a3daf18

File tree

1 file changed

+3
-1
lines changed
  • drivers/gpu/drm/nouveau/nvkm/subdev/gsp

1 file changed

+3
-1
lines changed

drivers/gpu/drm/nouveau/nvkm/subdev/gsp/base.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,10 @@ nvkm_gsp_new_(const struct nvkm_gsp_fwif *fwif, struct nvkm_device *device,
138138
nvkm_subdev_ctor(&nvkm_gsp, device, type, inst, &gsp->subdev);
139139

140140
fwif = nvkm_firmware_load(&gsp->subdev, fwif, "Gsp", gsp);
141-
if (IS_ERR(fwif))
141+
if (IS_ERR(fwif)) {
142+
nvkm_error(&gsp->subdev, "Failed to load required firmware for device.");
142143
return PTR_ERR(fwif);
144+
}
143145

144146
gsp->func = fwif->func;
145147

0 commit comments

Comments
 (0)