IB/cma: Fix reversed test

tititiou36 · dledford · commit a3dd3a48a5f6 · 2017-01-27T14:29:20.000-05:00
This test looks reverted.
We should log an error message only if 'ib_attach_mcast()' fails.

Signed-off-by: Christophe JAILLET &lt;christophe.jaillet@wanadoo.fr&gt;
Signed-off-by: Doug Ledford &lt;dledford@redhat.com&gt;
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
@@ -3837,7 +3837,7 @@ static int cma_ib_mc_handler(int status, struct ib_sa_multicast *multicast)
 	if (!status && id_priv->id.qp) {
 		status = ib_attach_mcast(id_priv->id.qp, &multicast->rec.mgid,
 					 be16_to_cpu(multicast->rec.mlid));
-		if (!status)
+		if (status)
 			pr_debug_ratelimited("RDMA CM: MULTICAST_ERROR: failed to attach QP. status %d\n",
 					     status);
 	}

Original file line number	Diff line number	Diff line change
`@@ -3837,7 +3837,7 @@ static int cma_ib_mc_handler(int status, struct ib_sa_multicast *multicast)`
`3837`	`3837`	`if (!status && id_priv->id.qp) {`
`3838`	`3838`	`status = ib_attach_mcast(id_priv->id.qp, &multicast->rec.mgid,`
`3839`	`3839`	`be16_to_cpu(multicast->rec.mlid));`
`3840`		`- if (!status)`
	`3840`	`+ if (status)`
`3841`	`3841`	`pr_debug_ratelimited("RDMA CM: MULTICAST_ERROR: failed to attach QP. status %d\n",`
`3842`	`3842`	`status);`
`3843`	`3843`	`}`