Skip to content

Commit a4cd2f3

Browse files
committed
Merge branch 'tools-ynl-gen-lift-type-requirement-for-attribute-subsets'
Jiri Pirko says: ==================== tools: ynl-gen: lift type requirement for attribute subsets Remove the requirement from schema files to specify the "type" for attribute subsets and adjust existing schema files. ==================== Link: https://lore.kernel.org/r/20231006114436.1725425-1-jiri@resnulli.us Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2 parents c042353 + 7049fd5 commit a4cd2f3

File tree

7 files changed

+52
-25
lines changed

7 files changed

+52
-25
lines changed

Documentation/netlink/genetlink-c.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ properties:
142142
type: array
143143
items:
144144
type: object
145-
required: [ name, type ]
145+
required: [ name ]
146146
additionalProperties: False
147147
properties:
148148
name:
@@ -215,6 +215,18 @@ properties:
215215
not:
216216
required: [ name-prefix ]
217217

218+
# type property is only required if not in subset definition
219+
if:
220+
properties:
221+
subset-of:
222+
not:
223+
type: string
224+
then:
225+
properties:
226+
attributes:
227+
items:
228+
required: [ type ]
229+
218230
operations:
219231
description: Operations supported by the protocol.
220232
type: object

Documentation/netlink/genetlink-legacy.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ properties:
180180
type: array
181181
items:
182182
type: object
183-
required: [ name, type ]
183+
required: [ name ]
184184
additionalProperties: False
185185
properties:
186186
name:
@@ -254,6 +254,18 @@ properties:
254254
not:
255255
required: [ name-prefix ]
256256

257+
# type property is only required if not in subset definition
258+
if:
259+
properties:
260+
subset-of:
261+
not:
262+
type: string
263+
then:
264+
properties:
265+
attributes:
266+
items:
267+
required: [ type ]
268+
257269
operations:
258270
description: Operations supported by the protocol.
259271
type: object

Documentation/netlink/genetlink.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ properties:
115115
type: array
116116
items:
117117
type: object
118-
required: [ name, type ]
118+
required: [ name ]
119119
additionalProperties: False
120120
properties:
121121
name:
@@ -184,6 +184,18 @@ properties:
184184
not:
185185
required: [ name-prefix ]
186186

187+
# type property is only required if not in subset definition
188+
if:
189+
properties:
190+
subset-of:
191+
not:
192+
type: string
193+
then:
194+
properties:
195+
attributes:
196+
items:
197+
required: [ type ]
198+
187199
operations:
188200
description: Operations supported by the protocol.
189201
type: object

Documentation/netlink/netlink-raw.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ properties:
187187
type: array
188188
items:
189189
type: object
190-
required: [ name, type ]
190+
required: [ name ]
191191
additionalProperties: False
192192
properties:
193193
name:
@@ -261,6 +261,18 @@ properties:
261261
not:
262262
required: [ name-prefix ]
263263

264+
# type property is only required if not in subset definition
265+
if:
266+
properties:
267+
subset-of:
268+
not:
269+
type: string
270+
then:
271+
properties:
272+
attributes:
273+
items:
274+
required: [ type ]
275+
264276
operations:
265277
description: Operations supported by the protocol.
266278
type: object

Documentation/netlink/specs/devlink.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,54 +199,44 @@ attribute-sets:
199199
attributes:
200200
-
201201
name: reload-stats
202-
type: nest
203202
-
204203
name: remote-reload-stats
205-
type: nest
206204
-
207205
name: dl-reload-stats
208206
subset-of: devlink
209207
attributes:
210208
-
211209
name: reload-action-info
212-
type: nest
213210
-
214211
name: dl-reload-act-info
215212
subset-of: devlink
216213
attributes:
217214
-
218215
name: reload-action
219-
type: u8
220216
-
221217
name: reload-action-stats
222-
type: nest
223218
-
224219
name: dl-reload-act-stats
225220
subset-of: devlink
226221
attributes:
227222
-
228223
name: reload-stats-entry
229-
type: nest
230224
-
231225
name: dl-reload-stats-entry
232226
subset-of: devlink
233227
attributes:
234228
-
235229
name: reload-stats-limit
236-
type: u8
237230
-
238231
name: reload-stats-value
239-
type: u32
240232
-
241233
name: dl-info-version
242234
subset-of: devlink
243235
attributes:
244236
-
245237
name: info-version-name
246-
type: string
247238
-
248239
name: info-version-value
249-
type: string
250240

251241
operations:
252242
enum-model: directional

Documentation/netlink/specs/dpll.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -278,36 +278,28 @@ attribute-sets:
278278
attributes:
279279
-
280280
name: parent-id
281-
type: u32
282281
-
283282
name: direction
284-
type: u32
285283
-
286284
name: prio
287-
type: u32
288285
-
289286
name: state
290-
type: u32
291287
-
292288
name: pin-parent-pin
293289
subset-of: pin
294290
attributes:
295291
-
296292
name: parent-id
297-
type: u32
298293
-
299294
name: state
300-
type: u32
301295
-
302296
name: frequency-range
303297
subset-of: pin
304298
attributes:
305299
-
306300
name: frequency-min
307-
type: u64
308301
-
309302
name: frequency-max
310-
type: u64
311303

312304
operations:
313305
enum-name: dpll_cmd

Documentation/netlink/specs/ethtool.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -818,13 +818,10 @@ attribute-sets:
818818
attributes:
819819
-
820820
name: hist-bkt-low
821-
type: u32
822821
-
823822
name: hist-bkt-hi
824-
type: u32
825823
-
826824
name: hist-val
827-
type: u64
828825
-
829826
name: stats
830827
attributes:

0 commit comments

Comments
 (0)