Skip to content

Commit acece9d

Browse files
kirankrishnappa-intelVudentz
authored andcommitted
Bluetooth: btintel: Direct exception event to bluetooth stack
Have exception event part of HCI traces which helps for debug. snoop traces: > HCI Event: Vendor (0xff) plen 79 Vendor Prefix (0x8780) Intel Extended Telemetry (0x03) Unknown extended telemetry event type (0xde) 01 01 de Unknown extended subevent 0x07 01 01 de 07 01 de 06 1c ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de 05 14 ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de 43 10 ef be ad de ef be ad de ef be ad de ef be ad de Fixes: af39533 ("Bluetooth: btintel: Add Intel devcoredump support") Signed-off-by: Kiran K <kiran.k@intel.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
1 parent 55abbd1 commit acece9d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/bluetooth/btintel.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3361,13 +3361,12 @@ int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb)
33613361
case INTEL_TLV_TEST_EXCEPTION:
33623362
/* Generate devcoredump from exception */
33633363
if (!hci_devcd_init(hdev, skb->len)) {
3364-
hci_devcd_append(hdev, skb);
3364+
hci_devcd_append(hdev, skb_clone(skb, GFP_ATOMIC));
33653365
hci_devcd_complete(hdev);
33663366
} else {
33673367
bt_dev_err(hdev, "Failed to generate devcoredump");
3368-
kfree_skb(skb);
33693368
}
3370-
return 0;
3369+
break;
33713370
default:
33723371
bt_dev_err(hdev, "Invalid exception type %02X", tlv->val[0]);
33733372
}

0 commit comments

Comments
 (0)