Skip to content

Commit aded5d1

Browse files
sreekanthbrcmkuba-moo
authored andcommitted
bnxt_en: Fix skb recycling logic in bnxt_deliver_skb()
Receive SKBs can go through the VF-rep path or the normal path. skb_mark_for_recycle() is only called for the normal path. Fix it to do it for both paths to fix possible stalled page pool shutdown errors. Fixes: 86b0550 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP") Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com> Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Link: https://lore.kernel.org/r/20231208001658.14230-3-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9ef7c58 commit aded5d1

File tree

1 file changed

+2
-1
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+2
-1
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1748,13 +1748,14 @@ static void bnxt_tpa_agg(struct bnxt *bp, struct bnxt_rx_ring_info *rxr,
17481748
static void bnxt_deliver_skb(struct bnxt *bp, struct bnxt_napi *bnapi,
17491749
struct sk_buff *skb)
17501750
{
1751+
skb_mark_for_recycle(skb);
1752+
17511753
if (skb->dev != bp->dev) {
17521754
/* this packet belongs to a vf-rep */
17531755
bnxt_vf_rep_rx(bp, skb);
17541756
return;
17551757
}
17561758
skb_record_rx_queue(skb, bnapi->index);
1757-
skb_mark_for_recycle(skb);
17581759
napi_gro_receive(&bnapi->napi, skb);
17591760
}
17601761

0 commit comments

Comments
 (0)