Skip to content

Commit ae697f3

Browse files
dtahtdavem330
authored andcommitted
Increase fq_codel count in the bulk dropper
In the field fq_codel is often used with a smaller memory or packet limit than the default, and when the bulk dropper is hit, the drop pattern bifircates into one that more slowly increases the codel drop rate and hits the bulk dropper more than it should. The scan through the 1024 queues happens more often than it needs to. This patch increases the codel count in the bulk dropper, but does not change the drop rate there, relying on the next codel round to deliver the next packet at the original drop rate (after that burst of loss), then escalate to a higher signaling rate. Signed-off-by: Dave Taht <dave.taht@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b8fb640 commit ae697f3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

net/sched/sch_fq_codel.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ static unsigned int fq_codel_drop(struct Qdisc *sch, unsigned int max_packets,
173173
__qdisc_drop(skb, to_free);
174174
} while (++i < max_packets && len < threshold);
175175

176+
/* Tell codel to increase its signal strength also */
177+
flow->cvars.count += i;
176178
flow->dropped += i;
177179
q->backlogs[idx] -= len;
178180
q->memory_usage -= mem;

0 commit comments

Comments
 (0)