Skip to content

Commit b2fe6be

Browse files
suganathprabu0512martinkpetersen
authored andcommitted
scsi: mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.
Return value and Device_handle Arguments passed in correct order to match with its format string. Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com> Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com> Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent f46e7cd commit b2fe6be

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/scsi/mpt3sas/mpt3sas_scsih.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2837,7 +2837,7 @@ _scsih_internal_device_block(struct scsi_device *sdev,
28372837
if (r == -EINVAL)
28382838
sdev_printk(KERN_WARNING, sdev,
28392839
"device_block failed with return(%d) for handle(0x%04x)\n",
2840-
sas_device_priv_data->sas_target->handle, r);
2840+
r, sas_device_priv_data->sas_target->handle);
28412841
}
28422842

28432843
/**
@@ -2867,20 +2867,20 @@ _scsih_internal_device_unblock(struct scsi_device *sdev,
28672867
sdev_printk(KERN_WARNING, sdev,
28682868
"device_unblock failed with return(%d) for handle(0x%04x) "
28692869
"performing a block followed by an unblock\n",
2870-
sas_device_priv_data->sas_target->handle, r);
2870+
r, sas_device_priv_data->sas_target->handle);
28712871
sas_device_priv_data->block = 1;
28722872
r = scsi_internal_device_block(sdev);
28732873
if (r)
28742874
sdev_printk(KERN_WARNING, sdev, "retried device_block "
28752875
"failed with return(%d) for handle(0x%04x)\n",
2876-
sas_device_priv_data->sas_target->handle, r);
2876+
r, sas_device_priv_data->sas_target->handle);
28772877

28782878
sas_device_priv_data->block = 0;
28792879
r = scsi_internal_device_unblock(sdev, SDEV_RUNNING);
28802880
if (r)
28812881
sdev_printk(KERN_WARNING, sdev, "retried device_unblock"
28822882
" failed with return(%d) for handle(0x%04x)\n",
2883-
sas_device_priv_data->sas_target->handle, r);
2883+
r, sas_device_priv_data->sas_target->handle);
28842884
}
28852885
}
28862886

0 commit comments

Comments
 (0)