net: fix __dst_destroy_metrics_generic()

Eric Dumazet · davem330 · commit b30c516f8750 · 2011-05-24T13:29:50.000-04:00
dst_default_metrics is readonly, we dont want to kfree() it later.

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/core/dst.c b/net/core/dst.c
@@ -315,7 +315,7 @@ void __dst_destroy_metrics_generic(struct dst_entry *dst, unsigned long old)
 {
 	unsigned long prev, new;
 
-	new = (unsigned long) dst_default_metrics;
+	new = ((unsigned long) dst_default_metrics) | DST_METRICS_READ_ONLY;
 	prev = cmpxchg(&dst->_metrics, old, new);
 	if (prev == old)
 		kfree(__DST_METRICS_PTR(old));

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ void __dst_destroy_metrics_generic(struct dst_entry *dst, unsigned long old)`
`315`	`315`	`{`
`316`	`316`	`unsigned long prev, new;`
`317`	`317`
`318`		`- new = (unsigned long) dst_default_metrics;`
	`318`	`+ new = ((unsigned long) dst_default_metrics) \| DST_METRICS_READ_ONLY;`
`319`	`319`	`prev = cmpxchg(&dst->_metrics, old, new);`
`320`	`320`	`if (prev == old)`
`321`	`321`	`kfree(__DST_METRICS_PTR(old));`