Skip to content

Commit b3840c8

Browse files
holger-denglerAlexander Gordeev
authored andcommitted
s390/ap: rename ap debug configuration option
The configuration option ZCRYPT_DEBUG is used only in ap queue code, so rename it to AP_DEBUG. It also no longer depends on ZCRYPT but on AP. While at it, also update the help text. Signed-off-by: Holger Dengler <dengler@linux.ibm.com> Reviewed-by: Harald Freudenberger <freude@linux.ibm.com> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
1 parent 1237608 commit b3840c8

File tree

3 files changed

+16
-19
lines changed

3 files changed

+16
-19
lines changed

arch/s390/Kconfig

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,20 @@ config AP
737737

738738
If unsure, say Y (default).
739739

740+
config AP_DEBUG
741+
def_bool n
742+
prompt "Enable debug features for Adjunct Processor (ap) devices"
743+
depends on AP
744+
help
745+
Say 'Y' here to enable some additional debug features for Adjunct
746+
Processor (ap) devices.
747+
748+
There will be some more sysfs attributes displayed for ap queues.
749+
750+
Do not enable on production level kernel build.
751+
752+
If unsure, say N.
753+
740754
config VFIO_CCW
741755
def_tristate n
742756
prompt "Support for VFIO-CCW subchannels"

drivers/crypto/Kconfig

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -75,23 +75,6 @@ config ZCRYPT
7575
to 8 in Coprocessor (CEXxC), EP11 Coprocessor (CEXxP)
7676
or Accelerator (CEXxA) mode.
7777

78-
config ZCRYPT_DEBUG
79-
bool "Enable debug features for s390 cryptographic adapters"
80-
default n
81-
depends on DEBUG_KERNEL
82-
depends on ZCRYPT
83-
help
84-
Say 'Y' here to enable some additional debug features on the
85-
s390 cryptographic adapters driver.
86-
87-
There will be some more sysfs attributes displayed for ap cards
88-
and queues and some flags on crypto requests are interpreted as
89-
debugging messages to force error injection.
90-
91-
Do not enable on production level kernel build.
92-
93-
If unsure, say N.
94-
9578
config PKEY
9679
tristate "Kernel API for protected key handling"
9780
depends on S390

drivers/s390/crypto/ap_queue.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,7 @@ static ssize_t ap_functions_show(struct device *dev,
708708

709709
static DEVICE_ATTR_RO(ap_functions);
710710

711-
#ifdef CONFIG_ZCRYPT_DEBUG
711+
#ifdef CONFIG_AP_DEBUG
712712
static ssize_t states_show(struct device *dev,
713713
struct device_attribute *attr, char *buf)
714714
{
@@ -820,7 +820,7 @@ static struct attribute *ap_queue_dev_attrs[] = {
820820
&dev_attr_config.attr,
821821
&dev_attr_chkstop.attr,
822822
&dev_attr_ap_functions.attr,
823-
#ifdef CONFIG_ZCRYPT_DEBUG
823+
#ifdef CONFIG_AP_DEBUG
824824
&dev_attr_states.attr,
825825
&dev_attr_last_err_rc.attr,
826826
#endif

0 commit comments

Comments
 (0)