Skip to content

Commit b98775b

Browse files
ShuichengLinlucasdemarchi
authored andcommitted
drm/xe/tile: Release kobject for the failure path
Call kobject_put() for the failure path to release the kobject v2: remove extra newline. (Matt) Fixes: e3d0839 ("drm/xe/tile: Abort driver load for sysfs creation failure") Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com> Link: https://lore.kernel.org/r/20250819153950.2973344-2-shuicheng.lin@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
1 parent 844150c commit b98775b

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

drivers/gpu/drm/xe/xe_tile_sysfs.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,18 @@ int xe_tile_sysfs_init(struct xe_tile *tile)
4444
kt->tile = tile;
4545

4646
err = kobject_add(&kt->base, &dev->kobj, "tile%d", tile->id);
47-
if (err) {
48-
kobject_put(&kt->base);
49-
return err;
50-
}
47+
if (err)
48+
goto err_object;
5149

5250
tile->sysfs = &kt->base;
5351

5452
err = xe_vram_freq_sysfs_init(tile);
5553
if (err)
56-
return err;
54+
goto err_object;
5755

5856
return devm_add_action_or_reset(xe->drm.dev, tile_sysfs_fini, tile);
57+
58+
err_object:
59+
kobject_put(&kt->base);
60+
return err;
5961
}

0 commit comments

Comments
 (0)