Skip to content

Commit badff5f

Browse files
committed
drm/i915/fbdev: Use fb->normal_view.gtt
Grab the GTT view for the fbdev fb pinning from fb->normal_view.gtt instead of having and extra one on the stack. Seems safer in case we ever put any new information into normal GTT views. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250122151755.6928-6-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com>
1 parent 4d291c4 commit badff5f

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/gpu/drm/i915/display/intel_fbdev.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,6 @@ static int intelfb_create(struct drm_fb_helper *helper,
177177
struct intel_framebuffer *fb = ifbdev->fb;
178178
struct drm_device *dev = helper->dev;
179179
struct drm_i915_private *dev_priv = to_i915(dev);
180-
const struct i915_gtt_view view = {
181-
.type = I915_GTT_VIEW_NORMAL,
182-
};
183180
intel_wakeref_t wakeref;
184181
struct fb_info *info;
185182
struct i915_vma *vma;
@@ -226,7 +223,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
226223
* This also validates that any existing fb inherited from the
227224
* BIOS is suitable for own access.
228225
*/
229-
vma = intel_fb_pin_to_ggtt(&fb->base, &view,
226+
vma = intel_fb_pin_to_ggtt(&fb->base, &fb->normal_view.gtt,
230227
fb->min_alignment, 0,
231228
intel_fb_view_vtd_guard(&fb->base, &fb->normal_view,
232229
DRM_MODE_ROTATE_0),

0 commit comments

Comments
 (0)