Skip to content

Commit bc08734

Browse files
Hans VerkuilMauro Carvalho Chehab
authored andcommitted
[media] cx231xx-417: use one querycap for all device nodes
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
1 parent 3f926e3 commit bc08734

File tree

3 files changed

+6
-22
lines changed

3 files changed

+6
-22
lines changed

drivers/media/usb/cx231xx/cx231xx-417.c

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1626,24 +1626,6 @@ static int vidioc_s_ctrl(struct file *file, void *priv,
16261626
dprintk(3, "exit vidioc_s_ctrl()\n");
16271627
return 0;
16281628
}
1629-
static struct v4l2_capability pvr_capability = {
1630-
.driver = "cx231xx",
1631-
.card = "VideoGrabber",
1632-
.bus_info = "usb",
1633-
.version = 1,
1634-
.capabilities = (V4L2_CAP_VIDEO_CAPTURE |
1635-
V4L2_CAP_TUNER | V4L2_CAP_AUDIO | V4L2_CAP_RADIO |
1636-
V4L2_CAP_STREAMING | V4L2_CAP_READWRITE),
1637-
};
1638-
static int vidioc_querycap(struct file *file, void *priv,
1639-
struct v4l2_capability *cap)
1640-
{
1641-
1642-
1643-
1644-
memcpy(cap, &pvr_capability, sizeof(struct v4l2_capability));
1645-
return 0;
1646-
}
16471629

16481630
static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv,
16491631
struct v4l2_fmtdesc *f)
@@ -2016,7 +1998,7 @@ static const struct v4l2_ioctl_ops mpeg_ioctl_ops = {
20161998
.vidioc_g_input = vidioc_g_input,
20171999
.vidioc_s_input = vidioc_s_input,
20182000
.vidioc_s_ctrl = vidioc_s_ctrl,
2019-
.vidioc_querycap = vidioc_querycap,
2001+
.vidioc_querycap = cx231xx_querycap,
20202002
.vidioc_enum_fmt_vid_cap = vidioc_enum_fmt_vid_cap,
20212003
.vidioc_g_fmt_vid_cap = vidioc_g_fmt_vid_cap,
20222004
.vidioc_try_fmt_vid_cap = vidioc_try_fmt_vid_cap,

drivers/media/usb/cx231xx/cx231xx-video.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1632,7 +1632,7 @@ static int vidioc_streamoff(struct file *file, void *priv,
16321632
return 0;
16331633
}
16341634

1635-
static int vidioc_querycap(struct file *file, void *priv,
1635+
int cx231xx_querycap(struct file *file, void *priv,
16361636
struct v4l2_capability *cap)
16371637
{
16381638
struct video_device *vdev = video_devdata(file);
@@ -2186,7 +2186,7 @@ static const struct v4l2_file_operations cx231xx_v4l_fops = {
21862186
};
21872187

21882188
static const struct v4l2_ioctl_ops video_ioctl_ops = {
2189-
.vidioc_querycap = vidioc_querycap,
2189+
.vidioc_querycap = cx231xx_querycap,
21902190
.vidioc_enum_fmt_vid_cap = vidioc_enum_fmt_vid_cap,
21912191
.vidioc_g_fmt_vid_cap = vidioc_g_fmt_vid_cap,
21922192
.vidioc_try_fmt_vid_cap = vidioc_try_fmt_vid_cap,
@@ -2237,7 +2237,7 @@ static const struct v4l2_file_operations radio_fops = {
22372237
};
22382238

22392239
static const struct v4l2_ioctl_ops radio_ioctl_ops = {
2240-
.vidioc_querycap = vidioc_querycap,
2240+
.vidioc_querycap = cx231xx_querycap,
22412241
.vidioc_g_tuner = radio_g_tuner,
22422242
.vidioc_s_tuner = radio_s_tuner,
22432243
.vidioc_g_frequency = vidioc_g_frequency,

drivers/media/usb/cx231xx/cx231xx.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -934,6 +934,8 @@ int cx231xx_register_extension(struct cx231xx_ops *dev);
934934
void cx231xx_unregister_extension(struct cx231xx_ops *dev);
935935
void cx231xx_init_extension(struct cx231xx *dev);
936936
void cx231xx_close_extension(struct cx231xx *dev);
937+
int cx231xx_querycap(struct file *file, void *priv,
938+
struct v4l2_capability *cap);
937939

938940
/* Provided by cx231xx-cards.c */
939941
extern void cx231xx_pre_card_setup(struct cx231xx *dev);

0 commit comments

Comments
 (0)