Skip to content

Commit c05bf0e

Browse files
kuba-moodavem330
authored andcommitted
selftests: ip_local_port_range: use XFAIL instead of SKIP
SCTP does not support IP_LOCAL_PORT_RANGE and we know it, so use XFAIL instead of SKIP. Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 2709473 commit c05bf0e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tools/testing/selftests/net/ip_local_port_range.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,6 @@ TEST_F(ip_local_port_range, late_bind)
365365
__u32 range;
366366
__u16 port;
367367

368-
if (variant->so_protocol == IPPROTO_SCTP)
369-
SKIP(return, "SCTP doesn't support IP_BIND_ADDRESS_NO_PORT");
370-
371368
fd = socket(variant->so_domain, variant->so_type, 0);
372369
ASSERT_GE(fd, 0) TH_LOG("socket failed");
373370

@@ -414,6 +411,9 @@ TEST_F(ip_local_port_range, late_bind)
414411
ASSERT_TRUE(!err) TH_LOG("close failed");
415412
}
416413

414+
XFAIL_ADD(ip_local_port_range, ip4_stcp, late_bind);
415+
XFAIL_ADD(ip_local_port_range, ip6_stcp, late_bind);
416+
417417
TEST_F(ip_local_port_range, get_port_range)
418418
{
419419
__u16 lo, hi;

0 commit comments

Comments
 (0)