Skip to content

Commit c3496c0

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: join: mark 'delete re-add signal' as skipped if not supported
The call to 'continue_if' was missing: it properly marks a subtest as 'skipped' if the attached condition is not valid. Without that, the test is wrongly marked as passed on older kernels. Fixes: b5e2fb8 ("selftests: mptcp: add explicit test case for remove/readd") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang <geliang@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-4-8207030cb0e8@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 973f80d commit c3496c0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4040,7 +4040,7 @@ endpoint_tests()
40404040

40414041
# remove and re-add
40424042
if reset_with_events "delete re-add signal" &&
4043-
mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
4043+
continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
40444044
ip netns exec $ns1 sysctl -q net.mptcp.add_addr_timeout=0
40454045
pm_nl_set_limits $ns1 0 3
40464046
pm_nl_set_limits $ns2 3 3

0 commit comments

Comments
 (0)