fs/ntfs3: Add rough attr alloc_size check

aalexandrovich · aalexandrovich · commit c4a8ba334262 · 2024-09-03T16:58:43.000+03:00
Reported-by: syzbot+c6d94bedd910a8216d25@syzkaller.appspotmail.com
Signed-off-by: Konstantin Komarov &lt;almaz.alexandrovich@paragon-software.com&gt;
diff --git a/fs/ntfs3/record.c b/fs/ntfs3/record.c
@@ -331,6 +331,9 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr)
 
 		if (attr->nres.c_unit)
 			return NULL;
+
+		if (alloc_size > mi->sbi->volume.size)
+			return NULL;
 	}
 
 	return attr;

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,9 @@ struct ATTRIB mi_enum_attr(struct mft_inode mi, struct ATTRIB *attr)`
`331`	`331`
`332`	`332`	`if (attr->nres.c_unit)`
`333`	`333`	`return NULL;`
	`334`	`+`
	`335`	`+ if (alloc_size > mi->sbi->volume.size)`
	`336`	`+ return NULL;`
`334`	`337`	`}`
`335`	`338`
`336`	`339`	`return attr;`