Skip to content

Commit c55e898

Browse files
LorenzoBianconinbd168
authored andcommitted
wifi: mt76: mt7603: rely on shared sta_poll_list and sta_poll_lock
Rely on sta_poll_list and sta_poll_lock fields in mt76_dev structure and get rid of private copies. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Felix Fietkau <nbd@nbd.name>
1 parent fbba711 commit c55e898

File tree

4 files changed

+13
-18
lines changed

4 files changed

+13
-18
lines changed

drivers/net/wireless/mediatek/mt76/mt7603/init.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,8 +500,6 @@ int mt7603_register_device(struct mt7603_dev *dev)
500500
bus_ops->rmw = mt7603_rmw;
501501
dev->mt76.bus = bus_ops;
502502

503-
INIT_LIST_HEAD(&dev->sta_poll_list);
504-
spin_lock_init(&dev->sta_poll_lock);
505503
spin_lock_init(&dev->ps_lock);
506504

507505
INIT_DELAYED_WORK(&dev->mphy.mac_work, mt7603_mac_work);

drivers/net/wireless/mediatek/mt76/mt7603/mac.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -412,16 +412,16 @@ void mt7603_mac_sta_poll(struct mt7603_dev *dev)
412412
while (1) {
413413
bool clear = false;
414414

415-
spin_lock_bh(&dev->sta_poll_lock);
416-
if (list_empty(&dev->sta_poll_list)) {
417-
spin_unlock_bh(&dev->sta_poll_lock);
415+
spin_lock_bh(&dev->mt76.sta_poll_lock);
416+
if (list_empty(&dev->mt76.sta_poll_list)) {
417+
spin_unlock_bh(&dev->mt76.sta_poll_lock);
418418
break;
419419
}
420420

421-
msta = list_first_entry(&dev->sta_poll_list, struct mt7603_sta,
422-
poll_list);
421+
msta = list_first_entry(&dev->mt76.sta_poll_list,
422+
struct mt7603_sta, poll_list);
423423
list_del_init(&msta->poll_list);
424-
spin_unlock_bh(&dev->sta_poll_lock);
424+
spin_unlock_bh(&dev->mt76.sta_poll_lock);
425425

426426
addr = mt7603_wtbl4_addr(msta->wcid.idx);
427427
for (i = 0; i < 4; i++) {
@@ -1268,9 +1268,9 @@ void mt7603_mac_add_txs(struct mt7603_dev *dev, void *data)
12681268
sta = wcid_to_sta(wcid);
12691269

12701270
if (list_empty(&msta->poll_list)) {
1271-
spin_lock_bh(&dev->sta_poll_lock);
1272-
list_add_tail(&msta->poll_list, &dev->sta_poll_list);
1273-
spin_unlock_bh(&dev->sta_poll_lock);
1271+
spin_lock_bh(&dev->mt76.sta_poll_lock);
1272+
list_add_tail(&msta->poll_list, &dev->mt76.sta_poll_list);
1273+
spin_unlock_bh(&dev->mt76.sta_poll_lock);
12741274
}
12751275

12761276
if (mt7603_mac_add_txs_skb(dev, msta, pid, txs_data))

drivers/net/wireless/mediatek/mt76/mt7603/main.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@ mt7603_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
100100

101101
rcu_assign_pointer(dev->mt76.wcid[idx], NULL);
102102

103-
spin_lock_bh(&dev->sta_poll_lock);
103+
spin_lock_bh(&dev->mt76.sta_poll_lock);
104104
if (!list_empty(&msta->poll_list))
105105
list_del_init(&msta->poll_list);
106-
spin_unlock_bh(&dev->sta_poll_lock);
106+
spin_unlock_bh(&dev->mt76.sta_poll_lock);
107107

108108
mutex_lock(&dev->mt76.mutex);
109109
dev->mt76.vif_mask &= ~BIT_ULL(mvif->idx);
@@ -388,10 +388,10 @@ mt7603_sta_remove(struct mt76_dev *mdev, struct ieee80211_vif *vif,
388388
mt7603_filter_tx(dev, wcid->idx, true);
389389
spin_unlock_bh(&dev->ps_lock);
390390

391-
spin_lock_bh(&dev->sta_poll_lock);
391+
spin_lock_bh(&mdev->sta_poll_lock);
392392
if (!list_empty(&msta->poll_list))
393393
list_del_init(&msta->poll_list);
394-
spin_unlock_bh(&dev->sta_poll_lock);
394+
spin_unlock_bh(&mdev->sta_poll_lock);
395395

396396
mt7603_wtbl_clear(dev, wcid->idx);
397397
}

drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,6 @@ struct mt7603_dev {
110110

111111
u32 rxfilter;
112112

113-
struct list_head sta_poll_list;
114-
spinlock_t sta_poll_lock;
115-
116113
struct mt7603_sta global_sta;
117114

118115
u32 agc0, agc3;

0 commit comments

Comments
 (0)