Skip to content

Commit cabbb6d

Browse files
teawaterakpm00
authored andcommitted
fs/proc/task_mmu.c: add_to_pagemap: remove useless parameter addr
Function parameter addr of add_to_pagemap() is useless. Remove it. Link: https://lkml.kernel.org/r/20240111084533.40038-1-teawaterz@linux.alibaba.com Signed-off-by: Hui Zhu <teawater@antgroup.com> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: Andrei Vagin <avagin@google.com> Cc: David Hildenbrand <david@redhat.com> Cc: Hugh Dickins <hughd@google.com> Cc: Kefeng Wang <wangkefeng.wang@huawei.com> Cc: Liam R. Howlett <Liam.Howlett@oracle.com> Cc: Peter Xu <peterx@redhat.com> Cc: Ryan Roberts <ryan.roberts@arm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 6b27cc6 commit cabbb6d

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

fs/proc/task_mmu.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,8 +1352,7 @@ static inline pagemap_entry_t make_pme(u64 frame, u64 flags)
13521352
return (pagemap_entry_t) { .pme = (frame & PM_PFRAME_MASK) | flags };
13531353
}
13541354

1355-
static int add_to_pagemap(unsigned long addr, pagemap_entry_t *pme,
1356-
struct pagemapread *pm)
1355+
static int add_to_pagemap(pagemap_entry_t *pme, struct pagemapread *pm)
13571356
{
13581357
pm->buffer[pm->pos++] = *pme;
13591358
if (pm->pos >= pm->len)
@@ -1380,7 +1379,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end,
13801379
hole_end = end;
13811380

13821381
for (; addr < hole_end; addr += PAGE_SIZE) {
1383-
err = add_to_pagemap(addr, &pme, pm);
1382+
err = add_to_pagemap(&pme, pm);
13841383
if (err)
13851384
goto out;
13861385
}
@@ -1392,7 +1391,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end,
13921391
if (vma->vm_flags & VM_SOFTDIRTY)
13931392
pme = make_pme(0, PM_SOFT_DIRTY);
13941393
for (; addr < min(end, vma->vm_end); addr += PAGE_SIZE) {
1395-
err = add_to_pagemap(addr, &pme, pm);
1394+
err = add_to_pagemap(&pme, pm);
13961395
if (err)
13971396
goto out;
13981397
}
@@ -1519,7 +1518,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
15191518
for (; addr != end; addr += PAGE_SIZE) {
15201519
pagemap_entry_t pme = make_pme(frame, flags);
15211520

1522-
err = add_to_pagemap(addr, &pme, pm);
1521+
err = add_to_pagemap(&pme, pm);
15231522
if (err)
15241523
break;
15251524
if (pm->show_pfn) {
@@ -1547,7 +1546,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
15471546
pagemap_entry_t pme;
15481547

15491548
pme = pte_to_pagemap_entry(pm, vma, addr, ptep_get(pte));
1550-
err = add_to_pagemap(addr, &pme, pm);
1549+
err = add_to_pagemap(&pme, pm);
15511550
if (err)
15521551
break;
15531552
}
@@ -1597,7 +1596,7 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask,
15971596
for (; addr != end; addr += PAGE_SIZE) {
15981597
pagemap_entry_t pme = make_pme(frame, flags);
15991598

1600-
err = add_to_pagemap(addr, &pme, pm);
1599+
err = add_to_pagemap(&pme, pm);
16011600
if (err)
16021601
return err;
16031602
if (pm->show_pfn && (flags & PM_PRESENT))

0 commit comments

Comments
 (0)